From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id DDA52385782C
 for <libc-alpha@sourceware.org>; Wed, 27 Apr 2022 10:48:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DDA52385782C
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-672-vu5y4kV6OEuCqmNi8-d5cw-1; Wed, 27 Apr 2022 06:48:25 -0400
X-MC-Unique: vu5y4kV6OEuCqmNi8-d5cw-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com
 [10.11.54.8])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3A3A4811E80;
 Wed, 27 Apr 2022 10:48:25 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.193.187])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 31163C4C7A6;
 Wed, 27 Apr 2022 10:48:23 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Noah Goldstein <goldstein.w.n@gmail.com>
Cc: Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 3/6] nss: Add tests for the nss_hash in nss_hash.h
References: <20220414041231.926415-1-goldstein.w.n@gmail.com>
 <20220414145540.194794-1-goldstein.w.n@gmail.com>
 <20220414145540.194794-3-goldstein.w.n@gmail.com>
 <87ee1lnpfe.fsf@oldenburg.str.redhat.com>
 <CAFUsyfL_kdRzVmPD_KEXcEjPzaMSX37+PTHfUtb4c_mCFGL1Pw@mail.gmail.com>
 <87pml4kzrk.fsf@oldenburg.str.redhat.com>
 <CAFUsyf+JhVvGPU2e41cbtUBB1axpgiCPBoVPLNF5asC9oyAP4g@mail.gmail.com>
Date: Wed, 27 Apr 2022 12:48:22 +0200
In-Reply-To: <CAFUsyf+JhVvGPU2e41cbtUBB1axpgiCPBoVPLNF5asC9oyAP4g@mail.gmail.com>
 (Noah Goldstein's message of "Tue, 26 Apr 2022 16:39:06 -0500")
Message-ID: <87a6c6iyyx.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Apr 2022 10:48:29 -0000

* Noah Goldstein:

> On Tue, Apr 26, 2022 at 3:36 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * Noah Goldstein:
>>
>> > On Mon, Apr 25, 2022 at 10:38 AM Florian Weimer <fweimer@redhat.com> wrote:
>> >>
>> >> * Noah Goldstein via Libc-alpha:
>> >>
>> >> > +static int
>> >> > +do_fill_tests (size_t len, int fill)
>> >> > +{
>> >> > +  uint32_t expec, res;
>> >> > +  char buf[len];
>> >> > +  memset (buf, fill, len);
>> >> > +
>> >> > +  expec = simple_nss_hash (buf, len);
>> >> > +  res = __nss_hash (buf, len);
>> >> > +  if (expec != res)
>> >> > +    {
>> >> > +      printf ("FAIL: fill(%d) (%lu), %x != %x\n", fill, len, expec, res);
>> >> > +      return 1;
>> >> > +    }
>> >> > +
>> >> > +  return 0;
>> >> > +}
>> >>
>> >> %lu needs to be %zu, otherwise this fails to build on various
>> >> architectures.
>> >
>> > Fixed in v3.
>>
>> Thanks; I can confirm the new version builds fine.
>>
>> Florian
>
> Thanks, good to push?

You said you wanted to post a v4, I think?

Anyway, I commented on a few nits.

Thanks,
Florian