From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by sourceware.org (Postfix) with ESMTPS id 6051F3858C83 for ; Mon, 21 Mar 2022 11:25:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6051F3858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4KMXNW6dZZz1s7t5; Mon, 21 Mar 2022 12:25:31 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4KMXNV6sbmz1qqkB; Mon, 21 Mar 2022 12:25:30 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id qW_ZY3YWeBjl; Mon, 21 Mar 2022 12:25:30 +0100 (CET) X-Auth-Info: utpXlNNx998MLxQBaycojy6kIqX9H2oKqXIRjDFN6zyK2WKq21EWifFZJxFOVIRR Received: from igel.home (ppp-46-244-184-176.dynamic.mnet-online.de [46.244.184.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 21 Mar 2022 12:25:30 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id BA32A2C3979; Mon, 21 Mar 2022 12:25:29 +0100 (CET) From: Andreas Schwab To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v3 7/7] misc: Use gmtime instead of localtime References: <20220318165214.2291065-1-adhemerval.zanella@linaro.org> <20220318165214.2291065-8-adhemerval.zanella@linaro.org> X-Yow: My FAVORITE group is "QUESTION MARK & THE MYSTERIANS"... Date: Mon, 21 Mar 2022 12:25:29 +0100 In-Reply-To: <20220318165214.2291065-8-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 18 Mar 2022 13:52:14 -0300") Message-ID: <87a6djo8d2.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 11:25:35 -0000 On Mär 18 2022, Adhemerval Zanella via Libc-alpha wrote: > diff --git a/misc/syslog.c b/misc/syslog.c > index 7852441615..997e423228 100644 > --- a/misc/syslog.c > +++ b/misc/syslog.c > @@ -161,11 +161,25 @@ __vsyslog_internal(int pri, const char *fmt, va_list ap, > > /* "%h %e %H:%M:%S " */ > char timestamp[timestamp_size]; > - time_t now = time_now (); > + __time64_t now = time64_now (); > + > + /* We deviate from RFC3164 which states timestamp should be in localtime > + because although our __localtime_r does not set tzname, the relay still > + might still use localtime (which does) and if the server timezone changes s/still...still/still/ -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."