From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org, dj@redhat.com,
Eyal Itkin <eyalit@checkpoint.com>
Subject: Re: [PATCH] Harden tcache double-free check
Date: Wed, 07 Jul 2021 19:17:19 +0200 [thread overview]
Message-ID: <87a6my2gdc.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210707012919.1298612-1-siddhesh@sourceware.org> (Siddhesh Poyarekar's message of "Wed, 7 Jul 2021 06:59:19 +0530")
* Siddhesh Poyarekar:
> +/* Process-wide key to try and catch a double-free in the same thread. */
> +static uintptr_t tcache_key;
> +
> +/* The value of tcache_key does not really have to be a cryptographically
> + secure random number. It only needs to be arbitrary enough so that it does
> + not collide with values present in applications, which would be quite rare,
> + about 1 in 2^wordsize. */
The comment should say that a collision could result in performance
problems.
Apart from that, the patch looks okay to me.
Thanks,
Florian
next prev parent reply other threads:[~2021-07-07 17:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 1:29 Siddhesh Poyarekar
2021-07-07 17:17 ` Florian Weimer [this message]
2021-07-07 17:34 ` [PATCH v2] " Siddhesh Poyarekar
2021-07-07 17:35 ` [PATCH] " Adhemerval Zanella
2021-07-07 17:58 ` Siddhesh Poyarekar
2021-07-07 18:09 ` Adhemerval Zanella
2021-07-07 18:12 ` Siddhesh Poyarekar
2021-07-07 18:27 ` Adhemerval Zanella
2021-07-07 18:28 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6my2gdc.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=dj@redhat.com \
--cc=eyalit@checkpoint.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).