public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Cc: "H.J. Lu" <hjl.tools@gmail.com>,  Joseph Myers <joseph@codesourcery.com>
Subject: Re: [PATCH v2] Define PTHREAD_STACK_MIN to sysconf(_SC_THREAD_STACK_MIN)
Date: Tue, 22 Jun 2021 11:29:31 +0200	[thread overview]
Message-ID: <87a6nidz7o.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210621221606.1295443-1-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Mon, 21 Jun 2021 15:16:06 -0700")

* H. J. Lu via Libc-alpha:

> The constant PTHREAD_STACK_MIN may be too small for some processors.
> When _SC_THREAD_STACK_MIN_SOURCE or _GNU_SOURCE are defined, define
> PTHREAD_STACK_MIN to sysconf(_SC_THREAD_STACK_MIN) which is changed
> to MIN (PTHREAD_STACK_MIN, sysconf(_SC_MINSIGSTKSZ)).

I think we should have a single feature test macro, not both
_SC_THREAD_STACK_MIN_SOURCE and _SC_SIGSTKSZ_SOURCE.  Maybe
_DYNAMIC_STACK_SIZE_SOURCE?

Thanks,
Florian


  reply	other threads:[~2021-06-22  9:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-21 22:16 H.J. Lu
2021-06-22  9:29 ` Florian Weimer [this message]
2021-06-22 14:22   ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6nidz7o.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).