From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 21D303858001 for ; Wed, 5 May 2021 17:28:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 21D303858001 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-37-pm1lpJR8OIeDNN3WbC_0IA-1; Wed, 05 May 2021 13:28:06 -0400 X-MC-Unique: pm1lpJR8OIeDNN3WbC_0IA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E6C4F1020C28; Wed, 5 May 2021 17:28:04 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-137.ams2.redhat.com [10.36.112.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E4CBE19102; Wed, 5 May 2021 17:28:03 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Cc: Adhemerval Zanella , crrodriguez@opensuse.org Subject: Re: [PATCH 1/4] Remove architecture specific sched_cpucount optimizations References: <20210329182520.323665-1-adhemerval.zanella@linaro.org> Date: Wed, 05 May 2021 19:28:20 +0200 In-Reply-To: <20210329182520.323665-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 29 Mar 2021 15:25:17 -0300") Message-ID: <87a6p9dr9n.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2021 17:28:11 -0000 * Adhemerval Zanella via Libc-alpha: > diff --git a/posix/sched_cpucount.c b/posix/sched_cpucount.c > index b0ca4ea7bc..529286e777 100644 > --- a/posix/sched_cpucount.c > +++ b/posix/sched_cpucount.c > @@ -22,31 +22,11 @@ int > __sched_cpucount (size_t setsize, const cpu_set_t *setp) > { > int s =3D 0; > + for (int i =3D 0; i < setsize / sizeof (__cpu_mask); i++) > { > + __cpu_mask si =3D setp->__bits[i]; > + /* Clear the least significant bit set. */ > + for (; si !=3D 0; si &=3D si - 1, s++); > } > - > return s; > } Why =E2=80=9Csi=E2=80=9D? It think si &=3D si - 1 clears the *most* signif= icant bit in si. If you agree, please update the comment. The rest looks okay to me. Thanks, Florian