public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Lukasz Majewski <lukma@denx.de>
Cc: Joseph Myers <joseph@codesourcery.com>,
	 Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	 Paul Eggert <eggert@cs.ucla.edu>,  Arnd Bergmann <arnd@arndb.de>,
	 GNU C Library <libc-alpha@sourceware.org>,
	Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH] support: Use __utimensat64 to set file access and modification times
Date: Wed, 17 Mar 2021 19:05:43 +0100	[thread overview]
Message-ID: <87a6r11wqw.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210317153810.12070-1-lukma@denx.de> (Lukasz Majewski's message of "Wed, 17 Mar 2021 16:38:10 +0100")

* Lukasz Majewski:

> @@ -49,8 +38,9 @@ support_path_support_time64 (const char *path)
>      { 0x80000001ULL, 0 },
>      { 0x80000002ULL, 0 }
>    };
> -  /* Return is kernel does not support __NR_utimensat_time64.  */
> -  if (utimesat_call (path, tsp) == -1)
> +
> +  /* Return if kernel does not support __NR_utimensat_time64.  */
> +  if (__utimensat64 (AT_FDCWD, path, &tsp[0], 0) == -1)
>      return false;
>  
>    /* Verify if the last access and last modification time match the ones
> @@ -67,7 +57,7 @@ support_path_support_time64 (const char *path)
>      { ostx.stx_atime.tv_sec, ostx.stx_atime.tv_nsec },
>      { ostx.stx_mtime.tv_sec, ostx.stx_mtime.tv_nsec },
>    };
> -  TEST_VERIFY_EXIT (utimesat_call (path, otsp) == 0);
> +  TEST_VERIFY_EXIT (__utimensat64 (AT_FDCWD, path, &otsp[0], 0) == 0);
>  
>    return support;
>  #else

I don't see how this can work given that __utimensat64 is currently a
symbol exported from libc.so.6.  Doesn't this result in link failures
on, say, i386?

Thanks,
Florian


  reply	other threads:[~2021-03-17 18:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 15:38 Lukasz Majewski
2021-03-17 18:05 ` Florian Weimer [this message]
2021-03-17 18:38   ` Adhemerval Zanella
2021-03-17 18:53     ` Florian Weimer
2021-03-17 22:32     ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6r11wqw.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=arnd@arndb.de \
    --cc=carlos@redhat.com \
    --cc=eggert@cs.ucla.edu \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=lukma@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).