From: Tulio Magno Quites Machado Filho <tuliom@ascii.art.br>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH 1/4] powerpc: Replace brk.S with a C implementation
Date: Thu, 19 Nov 2020 14:37:34 -0300 [thread overview]
Message-ID: <87a6vddz8h.fsf@linux.ibm.com> (raw)
In-Reply-To: <0baf4be2-7c9f-b83e-c89b-042fcae7b715@linaro.org>
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org> writes:
> On 18/11/2020 11:47, Matheus Castanho via Libc-alpha wrote:
>> From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>>
>> There is no need to maintain a separate assembly implementation of brk for
>> powerpc. It basically does the same thing as the generic C-based version, so we
>> can reuse that instead.
>
> LGTM. You also might want to check my brk consolidation [1], it
> consolidate not only powerpc, but all implementations.
>
> [1] https://sourceware.org/pipermail/libc-alpha/2020-November/119770.html
I think it's worth dropping this patch in favor of yours, Adhemerval.
--
Tulio Magno
next prev parent reply other threads:[~2020-11-19 17:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 14:46 [PATCH 0/4] powerpc: Add support for system call vectored Matheus Castanho
2020-11-18 14:47 ` [PATCH 1/4] powerpc: Replace brk.S with a C implementation Matheus Castanho
2020-11-18 20:00 ` Adhemerval Zanella
2020-11-19 17:37 ` Tulio Magno Quites Machado Filho [this message]
2020-11-18 21:28 ` Andreas Schwab
2020-11-18 14:47 ` [PATCH 2/4] powerpc: Make PT_THREAD_POINTER available to assembly code Matheus Castanho
2020-11-19 19:58 ` Tulio Magno Quites Machado Filho
2020-11-24 17:33 ` Matheus Castanho
2020-11-18 14:47 ` [PATCH 3/4] powerpc: Runtime selection between sc and scv for syscalls Matheus Castanho
2020-11-18 15:16 ` Florian Weimer
2020-11-19 20:29 ` Matheus Castanho
2020-11-19 20:35 ` Florian Weimer
2020-11-23 18:00 ` Matheus Castanho
2020-12-01 12:50 ` Matheus Castanho
2020-12-01 13:11 ` Florian Weimer
2020-12-01 13:35 ` Adhemerval Zanella
2020-12-03 17:19 ` Matheus Castanho
2020-11-18 19:00 ` Paul A. Clarke
2020-11-19 20:34 ` Matheus Castanho
2020-11-18 14:47 ` [PATCH 4/4] powerpc: Use scv instruction on clone when available Matheus Castanho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6vddz8h.fsf@linux.ibm.com \
--to=tuliom@ascii.art.br \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).