From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bird.elm.relay.mailchannels.net (bird.elm.relay.mailchannels.net [23.83.212.17]) by sourceware.org (Postfix) with ESMTPS id E408C386F826 for ; Thu, 19 Nov 2020 17:37:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E408C386F826 X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 75930641CB5; Thu, 19 Nov 2020 17:37:38 +0000 (UTC) Received: from pdx1-sub0-mail-a18.g.dreamhost.com (100-96-22-162.trex.outbound.svc.cluster.local [100.96.22.162]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E0CD3640CC5; Thu, 19 Nov 2020 17:37:37 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br Received: from pdx1-sub0-mail-a18.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.10); Thu, 19 Nov 2020 17:37:38 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|tuliom@ascii.art.br X-MailChannels-Auth-Id: dreamhost X-Sponge-Suffer: 087531a1270fe5f2_1605807458165_1267706401 X-MC-Loop-Signature: 1605807458165:2996063990 X-MC-Ingress-Time: 1605807458165 Received: from pdx1-sub0-mail-a18.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTP id 9DAB37F857; Thu, 19 Nov 2020 09:37:37 -0800 (PST) Received: from ascii.art.br (unknown [168.195.65.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tuliom@ascii.art.br) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 9A3277F155; Thu, 19 Nov 2020 09:37:36 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a18 From: Tulio Magno Quites Machado Filho To: Adhemerval Zanella , libc-alpha@sourceware.org Subject: Re: [PATCH 1/4] powerpc: Replace brk.S with a C implementation In-Reply-To: <0baf4be2-7c9f-b83e-c89b-042fcae7b715@linaro.org> References: <20201118144703.75569-1-msc@linux.ibm.com> <20201118144703.75569-2-msc@linux.ibm.com> <0baf4be2-7c9f-b83e-c89b-042fcae7b715@linaro.org> User-Agent: Notmuch/0.29.1 (http://notmuchmail.org) Emacs/26.3 (x86_64-redhat-linux-gnu) Date: Thu, 19 Nov 2020 14:37:34 -0300 Message-ID: <87a6vddz8h.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2020 17:37:42 -0000 Adhemerval Zanella via Libc-alpha writes: > On 18/11/2020 11:47, Matheus Castanho via Libc-alpha wrote: >> From: Tulio Magno Quites Machado Filho >> >> There is no need to maintain a separate assembly implementation of brk for >> powerpc. It basically does the same thing as the generic C-based version, so we >> can reuse that instead. > > LGTM. You also might want to check my brk consolidation [1], it > consolidate not only powerpc, but all implementations. > > [1] https://sourceware.org/pipermail/libc-alpha/2020-November/119770.html I think it's worth dropping this patch in favor of yours, Adhemerval. -- Tulio Magno