From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 75CD93895019 for ; Tue, 19 May 2020 14:21:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 75CD93895019 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=whitebox@nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 49RJ2k45VGz1qs3M; Tue, 19 May 2020 16:21:02 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 49RJ2k1MPmz1qqkR; Tue, 19 May 2020 16:21:02 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id qQ-VeLnhivD6; Tue, 19 May 2020 16:21:01 +0200 (CEST) X-Auth-Info: 6LJ4CW54jc2kxLuCin2AsY/wFRAcWEFd5SW2iv3M74/kUGYtwJRM7/+C7viviXRg Received: from igel.home (ppp-46-244-171-2.dynamic.mnet-online.de [46.244.171.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Tue, 19 May 2020 16:21:01 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id B3B252C0C39; Tue, 19 May 2020 16:21:00 +0200 (CEST) From: Andreas Schwab To: Chung-Lin Tang Cc: GNU C Library , Carlos O'Donell , cltang@codesourcery.com, Catherine Moore Subject: Re: [PATCH v2 1/2] BZ #17645, fix slow DSO sorting behavior in dynamic loader References: X-Yow: If I am elected no one will ever have to do their laundry again! Date: Tue, 19 May 2020 16:21:00 +0200 In-Reply-To: (Chung-Lin Tang's message of "Tue, 19 May 2020 21:24:41 +0800") Message-ID: <87a724uhtf.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 14:21:05 -0000 On Mai 19 2020, Chung-Lin Tang wrote: > +define include_dsosort_tests > +# We use the existence of the Makefile fragment file to indicate if we need to > +# regenerate all sources and script for this test file. > +$(shell if ! test -f "$(objpfx)$(1).tmp-makefile"; then \ > + $(PYTHON) $(..)scripts/dso-ordering-test.py --description-file $(1) \ > + --objpfx $(objpfx) --output-makefile $(objpfx)$(1).tmp-makefile; fi) > +include $(objpfx)$(1).tmp-makefile > +endef You can just write a rule that creates $(objpfx)$(1).tmp-makefile, no need to use $(shell). > +# Currently all tests are defined in description files, and this function is > +# not utilized, but kept here for possible conveniences. > +define single_dsosort_test > +$(shell $(PYTHON) $(..)scripts/dso-ordering-test.py --objpfx $(objpfx) \ > + $(2) $(1) $(3) --output-makefile $(objpfx)$(1).tmp-makefile) > +include $(objpfx)$(1).tmp-makefile > +endef Likewise. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."