public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: V2 [PATCH] x86: Add --enable-cet=permissive
Date: Mon, 18 May 2020 16:43:50 +0200	[thread overview]
Message-ID: <87a725b8wp.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOrWAKoiNgy=6CqYwsW=3oGzsstKo-g_OYwm0K-tfyRUpQ@mail.gmail.com> (H. J. Lu via Libc-alpha's message of "Mon, 18 May 2020 06:50:54 -0700")

* H. J. Lu via Libc-alpha:

> +  /* NB: dlopen should never fail on non-CET platforms.  If SHSTK is
> +     disabled, assuming IBT is also disabled.  */
> +  bool cet_enabled = _get_ssp () != 0 && !CET_MAYBE_DISABLED;
> +  if (fail && cet_enabled)
> +    FAIL_EXIT1 ("dlopen should have failed\n");

I think the multiple negatives are a bit difficult to understand here,
but I think the logic is correct.  (It's more obvious when looking at
the test as a whole.)

The patch looks okay to me.

Thanks,
Florian


      reply	other threads:[~2020-05-18 14:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 21:52 [PATCH 0/3] " H.J. Lu
2020-04-28 21:52 ` [PATCH 1/3] CET: Rename CET_MAX to CET_CONTROL_MASK [BZ #25887] H.J. Lu
2020-05-16 16:37   ` PING: " H.J. Lu
2020-05-16 17:27   ` Florian Weimer
2020-05-16 23:44     ` [PATCH] x86: Move CET control to _dl_x86_feature_control " H.J. Lu
2020-05-18  7:19       ` Florian Weimer
2020-05-18 12:26         ` V2 " H.J. Lu
2020-05-18 12:36           ` Florian Weimer
2020-04-28 21:52 ` [PATCH 2/3] rtld: Get architecture specific initializer in rtld_global H.J. Lu
2020-05-16 16:38   ` PING: " H.J. Lu
2020-05-16 17:51   ` Florian Weimer
2020-05-16 18:01     ` H.J. Lu
2020-05-16 18:07       ` Florian Weimer
2020-05-16 18:24         ` V2 [PATCH] " H.J. Lu
2020-04-28 21:52 ` [PATCH 3/3] x86: Add --enable-cet=permissive H.J. Lu
2020-04-29 17:19 ` [PATCH 0/3] " Adhemerval Zanella
2020-04-29 20:29   ` H.J. Lu
2020-04-29 20:46   ` Florian Weimer
2020-04-29 21:14     ` Adhemerval Zanella
2020-05-18 13:50       ` V2 [PATCH] " H.J. Lu
2020-05-18 14:43         ` Florian Weimer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a725b8wp.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).