From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id E853E388F04C for ; Mon, 18 May 2020 14:43:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E853E388F04C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-379-2tyb9KShOUSM2n1HjwA33w-1; Mon, 18 May 2020 10:43:54 -0400 X-MC-Unique: 2tyb9KShOUSM2n1HjwA33w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E43B453; Mon, 18 May 2020 14:43:52 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-142.ams2.redhat.com [10.36.112.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 16D141944E; Mon, 18 May 2020 14:43:51 +0000 (UTC) From: Florian Weimer To: "H.J. Lu via Libc-alpha" Subject: Re: V2 [PATCH] x86: Add --enable-cet=permissive References: <20200428215243.236312-1-hjl.tools@gmail.com> <87ees6ggvk.fsf@mid.deneb.enyo.de> <616cfb77-3aa3-fcbb-dacf-a0abbec9393e@linaro.org> Date: Mon, 18 May 2020 16:43:50 +0200 In-Reply-To: (H. J. Lu via Libc-alpha's message of "Mon, 18 May 2020 06:50:54 -0700") Message-ID: <87a725b8wp.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2020 14:44:00 -0000 * H. J. Lu via Libc-alpha: > + /* NB: dlopen should never fail on non-CET platforms. If SHSTK is > + disabled, assuming IBT is also disabled. */ > + bool cet_enabled = _get_ssp () != 0 && !CET_MAYBE_DISABLED; > + if (fail && cet_enabled) > + FAIL_EXIT1 ("dlopen should have failed\n"); I think the multiple negatives are a bit difficult to understand here, but I think the logic is correct. (It's more obvious when looking at the test as a whole.) The patch looks okay to me. Thanks, Florian