From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21]) by sourceware.org (Postfix) with ESMTPS id 8EAE9386F43F for ; Wed, 22 Apr 2020 08:32:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8EAE9386F43F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=deneb.enyo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1jRAnY-0007UV-9f; Wed, 22 Apr 2020 08:32:00 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.92) (envelope-from ) id 1jRAnY-0000NX-76; Wed, 22 Apr 2020 10:32:00 +0200 From: Florian Weimer To: Adhemerval Zanella Cc: Andreas Schwab , Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 4/4] signal: Only handle on NSIG signals on signal functions (BZ #25657) References: <20200313194827.4467-1-adhemerval.zanella@linaro.org> <20200313194827.4467-4-adhemerval.zanella@linaro.org> <87wo69q9tg.fsf@mid.deneb.enyo.de> <7daba627-610d-fc70-9227-ed5728869f9f@linaro.org> <87sggxq8uq.fsf@mid.deneb.enyo.de> <6a7af7ed-9a93-c8a6-7e7b-a9f3025f290b@linaro.org> <87k129q7aq.fsf@mid.deneb.enyo.de> <94cfdaa9-583e-dc6b-89dd-436051a0d2bb@linaro.org> <87ftcxq6el.fsf@mid.deneb.enyo.de> <87a734dgl6.fsf@igel.home> <87v9lspx3i.fsf@mid.deneb.enyo.de> <5f1f9083-6446-2b6b-f208-1fe2af34a43a@linaro.org> <875zdsd6na.fsf@igel.home> <6f988401-9b16-fb08-7c9c-852b6ae593fc@linaro.org> <87zhb4bkyd.fsf@igel.home> Date: Wed, 22 Apr 2020 10:32:00 +0200 In-Reply-To: <87zhb4bkyd.fsf@igel.home> (Andreas Schwab's message of "Tue, 21 Apr 2020 23:14:18 +0200") Message-ID: <87a733ncov.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 08:32:03 -0000 * Andreas Schwab: > On Apr 21 2020, Adhemerval Zanella wrote: > >> On 21/04/2020 15:40, Andreas Schwab wrote: >>> On Apr 21 2020, Adhemerval Zanella wrote: >>>=20 >>>> I have added the following comment on linux sigsetopts.h: >>>> >>>> /* Linux sig* functions only handle up to __NSIG_WORDS words instead= of >>>> full _SIGSET_NWORDS sigset size. The signal numbers are 1-based,= and >>>> bit 0 of a signal mask is for signal 1. */ >>>=20 >>> You forgot to fix __NSIG_WORDS. >> >> Hum what exactly? I missing to see what might be missing here. Is the >> related to comment or the __NSIG_WORDS value itself? > > The problem really is that _NSIG is bogus, it is actually the number of > signals plus one. That doesn't change the value of __NSIG_WORDS, but if > there would actually be 65 signals then __NSIG_WORDS would be too small. > > Note also that mips has the wrong value for __SIGRTMAX (it should be > 128). Adhemerval, if you address this, please also fix these whitespace issue: +# define __NSIG_WORDS (_NSIG / (8 * sizeof (unsigned long int ))) (Space before define (it's not nested) and after =E2=80=9Cunsigned long int= =E2=80=9D.)