public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Add --enable-static-c++-link-check option [BZ #31412]
Date: Sat, 25 May 2024 18:07:59 +0200	[thread overview]
Message-ID: <87bk4tyiw0.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOr+zHpFOTedgw_JbXgmt-bhwEq3EqVy6FgVtyND9o1Z5A@mail.gmail.com> (H. J. Lu's message of "Sat, 25 May 2024 03:44:42 -0700")

* H. J. Lu:

> On Sat, May 25, 2024 at 2:54 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * H. J. Lu:
>>
>> > The current minimum GCC version of glibc build is GCC 6.2 or newer.  When
>> > building i686 glibc on Fedora 40, GCC 6.4 failed the static C++ link test
>> > since the 32-bit libc.a was built with GCC 14 and has references to
>> > __divmoddi4 which was added to GCC 7.  Add --enable-static-c++-link-check
>> > configure option which is on by default.  --disable-static-c++-link-check
>> > can be used to disable the static C++ link test.  The newly built i686
>> > libc.a can be used by GCC 6.4 to create static C++ tests.  This fixes
>> > BZ #31412.
>>
>> But won't there still be tons of test suite failures?
>
> I only saw
>
> FAIL: misc/tst-pidfd
> FAIL: misc/tst-pidfd_getpid
>
> with GCC 6.4.  I will check if it is a testcase issue.
>
>> Even CXX=no will not work because in some configurations, it's actually
>> libgcc_s.so.1 that can't be loaded, and that breaks pthread_cancel.
>>
>
> c++ still works.  Only "c++ -static" doesn't work with the system libc.a.

I think you'll see the issue if you go back further, to the 2.34 branch.

Thanks,
Florian


  reply	other threads:[~2024-05-25 16:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 21:57 H.J. Lu
2024-05-25  9:54 ` Florian Weimer
2024-05-25 10:44   ` H.J. Lu
2024-05-25 16:07     ` Florian Weimer [this message]
2024-05-25 16:14       ` H.J. Lu
2024-05-26 14:07         ` Florian Weimer
2024-05-26 14:26           ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk4tyiw0.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).