* [PATCH] test_printers_common.py: Remove invalid escape sequence
@ 2024-02-12 13:35 H.J. Lu
2024-02-12 13:44 ` Andreas Schwab
2024-02-12 13:47 ` Florian Weimer
0 siblings, 2 replies; 6+ messages in thread
From: H.J. Lu @ 2024-02-12 13:35 UTC (permalink / raw)
To: libc-alpha
Remove '\(' and '\)' from test_printers_common.py which aren't valid
Python escape sequences. This fixes the test warning:
.../scripts/test_printers_common.py:101: SyntaxWarning: invalid escape sequence '\('
---
scripts/test_printers_common.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/test_printers_common.py b/scripts/test_printers_common.py
index bf700966ac..7085a2fbc2 100644
--- a/scripts/test_printers_common.py
+++ b/scripts/test_printers_common.py
@@ -98,7 +98,7 @@ try:
# If everything's ok, spawn the gdb process we'll use for testing.
gdb = pexpect.spawn(gdb_invocation, echo=False, timeout=timeout,
encoding=encoding)
- gdb_prompt = u'\(gdb\)'
+ gdb_prompt = u'(gdb)'
gdb.expect(gdb_prompt)
except pexpect.ExceptionPexpect as exception:
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] test_printers_common.py: Remove invalid escape sequence
2024-02-12 13:35 [PATCH] test_printers_common.py: Remove invalid escape sequence H.J. Lu
@ 2024-02-12 13:44 ` Andreas Schwab
2024-02-12 13:47 ` Florian Weimer
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Schwab @ 2024-02-12 13:44 UTC (permalink / raw)
To: H.J. Lu; +Cc: libc-alpha
On Feb 12 2024, H.J. Lu wrote:
> diff --git a/scripts/test_printers_common.py b/scripts/test_printers_common.py
> index bf700966ac..7085a2fbc2 100644
> --- a/scripts/test_printers_common.py
> +++ b/scripts/test_printers_common.py
> @@ -98,7 +98,7 @@ try:
> # If everything's ok, spawn the gdb process we'll use for testing.
> gdb = pexpect.spawn(gdb_invocation, echo=False, timeout=timeout,
> encoding=encoding)
> - gdb_prompt = u'\(gdb\)'
> + gdb_prompt = u'(gdb)'
When that's a regexp it needs to be '\\(gdb\\)'.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] test_printers_common.py: Remove invalid escape sequence
2024-02-12 13:35 [PATCH] test_printers_common.py: Remove invalid escape sequence H.J. Lu
2024-02-12 13:44 ` Andreas Schwab
@ 2024-02-12 13:47 ` Florian Weimer
2024-02-12 13:55 ` H.J. Lu
1 sibling, 1 reply; 6+ messages in thread
From: Florian Weimer @ 2024-02-12 13:47 UTC (permalink / raw)
To: H.J. Lu; +Cc: libc-alpha
* H. J. Lu:
> Remove '\(' and '\)' from test_printers_common.py which aren't valid
> Python escape sequences. This fixes the test warning:
>
> .../scripts/test_printers_common.py:101: SyntaxWarning: invalid escape sequence '\('
> ---
> scripts/test_printers_common.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/test_printers_common.py b/scripts/test_printers_common.py
> index bf700966ac..7085a2fbc2 100644
> --- a/scripts/test_printers_common.py
> +++ b/scripts/test_printers_common.py
> @@ -98,7 +98,7 @@ try:
> # If everything's ok, spawn the gdb process we'll use for testing.
> gdb = pexpect.spawn(gdb_invocation, echo=False, timeout=timeout,
> encoding=encoding)
> - gdb_prompt = u'\(gdb\)'
> + gdb_prompt = u'(gdb)'
> gdb.expect(gdb_prompt)
>
> except pexpect.ExceptionPexpect as exception:
This changes the string, you should use:
+ gdb_prompt = u'\\(gdb\\)'
Thanks,
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] test_printers_common.py: Remove invalid escape sequence
2024-02-12 13:47 ` Florian Weimer
@ 2024-02-12 13:55 ` H.J. Lu
2024-02-12 14:03 ` Florian Weimer
0 siblings, 1 reply; 6+ messages in thread
From: H.J. Lu @ 2024-02-12 13:55 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On Mon, Feb 12, 2024 at 5:47 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu:
>
> > Remove '\(' and '\)' from test_printers_common.py which aren't valid
> > Python escape sequences. This fixes the test warning:
> >
> > .../scripts/test_printers_common.py:101: SyntaxWarning: invalid escape sequence '\('
> > ---
> > scripts/test_printers_common.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/test_printers_common.py b/scripts/test_printers_common.py
> > index bf700966ac..7085a2fbc2 100644
> > --- a/scripts/test_printers_common.py
> > +++ b/scripts/test_printers_common.py
> > @@ -98,7 +98,7 @@ try:
> > # If everything's ok, spawn the gdb process we'll use for testing.
> > gdb = pexpect.spawn(gdb_invocation, echo=False, timeout=timeout,
> > encoding=encoding)
> > - gdb_prompt = u'\(gdb\)'
> > + gdb_prompt = u'(gdb)'
> > gdb.expect(gdb_prompt)
> >
> > except pexpect.ExceptionPexpect as exception:
>
> This changes the string, you should use:
>
> + gdb_prompt = u'\\(gdb\\)'
>
This change, \\( and \\), causes:
FAIL: nptl/test-cond-printers
FAIL: nptl/test-condattr-printers
FAIL: nptl/test-mutex-printers
FAIL: nptl/test-mutexattr-printers
FAIL: nptl/test-rwlock-printers
FAIL: nptl/test-rwlockattr-printers
My change doesn't have any regression.
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] test_printers_common.py: Remove invalid escape sequence
2024-02-12 13:55 ` H.J. Lu
@ 2024-02-12 14:03 ` Florian Weimer
2024-02-12 14:07 ` H.J. Lu
0 siblings, 1 reply; 6+ messages in thread
From: Florian Weimer @ 2024-02-12 14:03 UTC (permalink / raw)
To: H.J. Lu; +Cc: libc-alpha
* H. J. Lu:
> On Mon, Feb 12, 2024 at 5:47 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * H. J. Lu:
>>
>> > Remove '\(' and '\)' from test_printers_common.py which aren't valid
>> > Python escape sequences. This fixes the test warning:
>> >
>> > .../scripts/test_printers_common.py:101: SyntaxWarning: invalid escape sequence '\('
>> > ---
>> > scripts/test_printers_common.py | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/scripts/test_printers_common.py b/scripts/test_printers_common.py
>> > index bf700966ac..7085a2fbc2 100644
>> > --- a/scripts/test_printers_common.py
>> > +++ b/scripts/test_printers_common.py
>> > @@ -98,7 +98,7 @@ try:
>> > # If everything's ok, spawn the gdb process we'll use for testing.
>> > gdb = pexpect.spawn(gdb_invocation, echo=False, timeout=timeout,
>> > encoding=encoding)
>> > - gdb_prompt = u'\(gdb\)'
>> > + gdb_prompt = u'(gdb)'
>> > gdb.expect(gdb_prompt)
>> >
>> > except pexpect.ExceptionPexpect as exception:
>>
>> This changes the string, you should use:
>>
>> + gdb_prompt = u'\\(gdb\\)'
>>
>
> This change, \\( and \\), causes:
>
> FAIL: nptl/test-cond-printers
> FAIL: nptl/test-condattr-printers
> FAIL: nptl/test-mutex-printers
> FAIL: nptl/test-mutexattr-printers
> FAIL: nptl/test-rwlock-printers
> FAIL: nptl/test-rwlockattr-printers
>
> My change doesn't have any regression.
I don't understand that. Python 2.7.5 and 3.11.7 treat u'\(gdb\)' as
u'\\(gdb\\)'.
Thanks,
Florian
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] test_printers_common.py: Remove invalid escape sequence
2024-02-12 14:03 ` Florian Weimer
@ 2024-02-12 14:07 ` H.J. Lu
0 siblings, 0 replies; 6+ messages in thread
From: H.J. Lu @ 2024-02-12 14:07 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
On Mon, Feb 12, 2024 at 6:03 AM Florian Weimer <fweimer@redhat.com> wrote:
>
> * H. J. Lu:
>
> > On Mon, Feb 12, 2024 at 5:47 AM Florian Weimer <fweimer@redhat.com> wrote:
> >>
> >> * H. J. Lu:
> >>
> >> > Remove '\(' and '\)' from test_printers_common.py which aren't valid
> >> > Python escape sequences. This fixes the test warning:
> >> >
> >> > .../scripts/test_printers_common.py:101: SyntaxWarning: invalid escape sequence '\('
> >> > ---
> >> > scripts/test_printers_common.py | 2 +-
> >> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >> >
> >> > diff --git a/scripts/test_printers_common.py b/scripts/test_printers_common.py
> >> > index bf700966ac..7085a2fbc2 100644
> >> > --- a/scripts/test_printers_common.py
> >> > +++ b/scripts/test_printers_common.py
> >> > @@ -98,7 +98,7 @@ try:
> >> > # If everything's ok, spawn the gdb process we'll use for testing.
> >> > gdb = pexpect.spawn(gdb_invocation, echo=False, timeout=timeout,
> >> > encoding=encoding)
> >> > - gdb_prompt = u'\(gdb\)'
> >> > + gdb_prompt = u'(gdb)'
> >> > gdb.expect(gdb_prompt)
> >> >
> >> > except pexpect.ExceptionPexpect as exception:
> >>
> >> This changes the string, you should use:
> >>
> >> + gdb_prompt = u'\\(gdb\\)'
> >>
> >
> > This change, \\( and \\), causes:
> >
> > FAIL: nptl/test-cond-printers
> > FAIL: nptl/test-condattr-printers
> > FAIL: nptl/test-mutex-printers
> > FAIL: nptl/test-mutexattr-printers
> > FAIL: nptl/test-rwlock-printers
> > FAIL: nptl/test-rwlockattr-printers
> >
> > My change doesn't have any regression.
>
> I don't understand that. Python 2.7.5 and 3.11.7 treat u'\(gdb\)' as
> u'\\(gdb\\)'.
>
> Thanks,
> Florian
>
Pilot error. Sent v2.
--
H.J.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-12 14:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-12 13:35 [PATCH] test_printers_common.py: Remove invalid escape sequence H.J. Lu
2024-02-12 13:44 ` Andreas Schwab
2024-02-12 13:47 ` Florian Weimer
2024-02-12 13:55 ` H.J. Lu
2024-02-12 14:03 ` Florian Weimer
2024-02-12 14:07 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).