Re: [PATCH v2 3/3] elf: Always call destructors in reverse constructor order

[Florian Weimer <fweimer@redhat.com>]

* Adhemerval Zanella:

>>  #ifdef SHARED
>> -  int do_audit = 0;
>> - again:
>> +  int last_pass = GLRO(dl_naudit) > 0;
>> +  Lmid_t last_ns = -1;	     /* Avoid some LA_ACT_DELETE callouts.  */
>
> This has caused as lot of audit regressions, since it will make
> _dl_audit_activity_nsid access
>
>   struct link_map *head = GL(dl_ns)[-1]._ns_loaded;

>> -	  _dl_audit_activity_nsid (ns, LA_ACT_DELETE);
>> +	if (GL(dl_ns)[l->l_ns]._ns_loaded->l_auditing != do_audit)
>> +	  continue;
>> +
>> +	if (last_ns != l->l_ns)
>> +	  {
>
> I think you will need a
>
>    if (last_ns != -1)
>      _dl_audit_activity_nsid (last_ns, LA_ACT_CONSISTENT);

Thanks, somehow I missed your comment.  I will resend a v3.

Florian