Re: [PATCH v3 3/3] statvfs: f_type: NEWS & test

[Florian Weimer <fweimer@redhat.com>]

* наб:

> Subject: [PATCH] io/tst-statvfs: fix statfs().f_type comparison test on some
>  arches
>
> On i686 f_type is an i32 so the test fails when that has the top bit set.
>
> Explicitly cast to u32.
>
> Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
> ---
>  io/tst-statvfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/io/tst-statvfs.c b/io/tst-statvfs.c
> index f3097ce1a8..fb23733667 100644
> --- a/io/tst-statvfs.c
> +++ b/io/tst-statvfs.c
> @@ -16,7 +16,7 @@ do_test (int argc, char *argv[])
>        struct statfs stf;
>        TEST_COMPARE (statvfs (argv[i], &st), 0);
>        TEST_COMPARE (statfs (argv[i], &stf), 0);
> -      TEST_COMPARE (st.f_type, stf.f_type);
> +      TEST_COMPARE (st.f_type, (unsigned int) stf.f_type);
>        printf ("%s: free: %llu, mandatory: %s, tp=%x\n", argv[i],
>                (unsigned long long int) st.f_bfree,
>  #ifdef ST_MANDLOCK

Looks good.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Can you install this yourself, or should I push it?

Thanks,
Florian