From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 155E83858C5F for ; Thu, 11 May 2023 17:56:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 155E83858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683827785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GGrsUF1hGFScBBF6OohUOy3vutP+4TDDOX2IHKCPAoo=; b=F3t/8Vsw8npSvgCbPfHZtsBTwx4UOQanTMTWNSmB12XVI5qYYplI9HlKrP96QHbIkyAMmw rxE9NnucD2tQWk7jnQSipZktLsdEuMrYP/C5HLpULJablHPIQVwxdL7fq6XiJ65+zUZwgs yxcI8FI5N60IVWdbpOuHeQFMEWnhGxk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-544-Xs4FK6YBMGej6IjqzLgSBA-1; Thu, 11 May 2023 13:56:24 -0400 X-MC-Unique: Xs4FK6YBMGej6IjqzLgSBA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 39830101A54F; Thu, 11 May 2023 17:56:24 +0000 (UTC) Received: from oldenburg3.str.redhat.com (unknown [10.39.195.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 889E2C15BA0; Thu, 11 May 2023 17:56:23 +0000 (UTC) From: Florian Weimer To: Sergey Bugaev Cc: libc-alpha@sourceware.org, bug-hurd Subject: Re: __pthread_setcancelstate called unconditionally, crashes at 0 References: <87ilcyg3ud.fsf@oldenburg3.str.redhat.com> <20230511175241.ohixyohfjsaoo3yq@begin> Date: Thu, 11 May 2023 19:56:22 +0200 In-Reply-To: <20230511175241.ohixyohfjsaoo3yq@begin> (Samuel Thibault's message of "Thu, 11 May 2023 19:52:41 +0200") Message-ID: <87bkiqg3ax.fsf@oldenburg3.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Samuel Thibault: > Florian Weimer, le jeu. 11 mai 2023 19:44:42 +0200, a ecrit: >> * Sergey Bugaev: >> > Clearly __pthread_setcancelstate has been pragma weak'd, and used here >> > without a check. This is a statically linked x86_64-gnu (so, Hurd and >> > HTL) executable. Commit 93d78ec1cba68184931b75bef29afd3aed30f43a >> > "nptl: Move pthread_setcancelstate into libc" seems to be the culprit: >> > that commit only moved the NPTL symbol into libc, yet changed the >> > original __libc_ptf_call (__pthread_setcancelstate) calls to direct >> > __pthread_setcancelstate calls, in this and many other places. >> >> Apparently, Hurd does not support async cancellation? > > ? It does, see htl/pt-cancel.c's check for > PTHREAD_CANCEL_ASYNCHRONOUS. But __pthread_setcancelstate does not trigger async cancellation if there's a pending async request and cancellation is enabled. Thanks, Florian