From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 89168385B51F for ; Mon, 20 Feb 2023 13:21:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89168385B51F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676899306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d7Im6BF+ZZ9ywToMCNr/u8De4JGROedKqCQaO4e/Hec=; b=INaOOuYu6d02CXtoKmLKmMicQsjHEzBzTKQUReyxOiDnQQqzhqkXUhptg62dCO0RKh8J17 HfSk3rc1eMG7aIyEsnQN7Md6bBl1p2uolWBjJTi/ckIinE9AqNWWO8s4XAv9a2yys8ohjY uWV3qDbvOz1grpsKZGFh10+Elyen3iE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-132-z5Fjku3uPWaBHSXP6sFHNA-1; Mon, 20 Feb 2023 08:21:42 -0500 X-MC-Unique: z5Fjku3uPWaBHSXP6sFHNA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 85BB5802C16; Mon, 20 Feb 2023 13:21:41 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.38]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A38C4492B00; Mon, 20 Feb 2023 13:21:40 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto via Libc-alpha Cc: Joan Bruguera , Adhemerval Zanella Netto Subject: Re: [PATCH v4] elf: Restore ldconfig libc6 implicit soname logic [BZ #30125] References: <20230216020810.3947682-1-joanbrugueram@gmail.com> <20230218215215.3930119-1-joanbrugueram@gmail.com> Date: Mon, 20 Feb 2023 14:21:38 +0100 In-Reply-To: (Adhemerval Zanella Netto via Libc-alpha's message of "Mon, 20 Feb 2023 09:32:21 -0300") Message-ID: <87bkloh3q5.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella Netto via Libc-alpha: > On 18/02/23 18:52, Joan Bruguera wrote: >> While cleaning up old libc version support, the deprecated libc4 code was >> accidentally kept in `implicit_soname`, instead of the libc6 code. >> >> This causes additional symlinks to be created by `ldconfig` for libraries >> without a soname, e.g. a library `libsomething.123.456.789` without a soname >> will create a `libsomething.123` -> `libsomething.123.456.789` symlink. >> >> As the libc6 version of the `implicit_soname` code is a trivial `xstrdup`, >> just inline it and remove `implicit_soname` altogether. >> >> Some further simplification looks possible (e.g. the call to `create_links` >> looks like a no-op if `soname == NULL`, other than the verbose printfs), but >> logic is kept as-is for now. >> >> Fixes: BZ #30125 >> Fixes: 8ee878592c4a ("Assume only FLAG_ELF_LIBC6 suport") >> Signed-off-by: Joan Bruguera > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella Reviewed-by: Florian Weimer Are you going to push & backport this to glibc 2.37? Thanks, Florian