public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Job Snijders via Libc-alpha <libc-alpha@sourceware.org>
Cc: Job Snijders <job@fastly.com>
Subject: Re: [PATCH] resolv: add IPv6 support to inet_net_pton()
Date: Thu, 22 Dec 2022 19:21:24 +0100	[thread overview]
Message-ID: <87bknvmh97.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <Y6SZ8uYIeHCDgCp/@snel> (Job Snijders via Libc-alpha's message of "Thu, 22 Dec 2022 18:54:58 +0100")

* Job Snijders via Libc-alpha:

> +	strncpy(buf, src, sizeof(buf) - 1);
> +	buf[sizeof(buf) - 1] = '\0';
> +
> +	sep = strchr(buf, '/');
> +	if (sep != NULL)
> +		*sep++ = '\0';
> +
> +	if (inet_pton(AF_INET6, buf, &in6) != 1) {
> +		__set_errno (ENOENT);
> +		return (-1);
> +	}

Thanks for the patch.

We have __inet_pton_length for internal use.  You can use it to avoid
the copy.  Would you be interested in reworking your patch based on it?

Florian


  reply	other threads:[~2022-12-22 18:21 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-22 17:54 Job Snijders
2022-12-22 18:21 ` Florian Weimer [this message]
2022-12-22 18:28 ` copying a string with truncation (was: [PATCH] resolv: add IPv6 support to inet_net_pton()) Alejandro Colomar
2022-12-22 20:25   ` Alejandro Colomar
2022-12-23  6:55     ` Sam James
2022-12-23  7:00       ` Sam James
2022-12-23 11:42         ` Alejandro Colomar
2022-12-23 11:45           ` Alejandro Colomar
2022-12-31 15:11           ` Sam James
2023-01-17 10:56 ` [PATCH] resolv: add IPv6 support to inet_net_pton() Job Snijders
2023-04-19 11:31   ` Job Snijders
2024-03-17  1:23 ` Job Snijders
2024-03-17  3:19   ` Job Snijders
2024-03-17 11:18     ` Florian Weimer
2024-03-18  8:59       ` Job Snijders
2024-03-18  9:23         ` Andreas Schwab
2024-03-18 23:01           ` Job Snijders
2024-03-19  8:20             ` Andreas Schwab
2024-03-19  8:29               ` Job Snijders
2024-03-19  9:50                 ` Andreas Schwab
2024-03-22  4:16                   ` Job Snijders
2024-03-22 14:24                     ` Zack Weinberg
2024-03-25  9:04                       ` Job Snijders
2024-04-14 14:56                         ` Job Snijders
2024-04-15  8:15                           ` Xi Ruoyao
2024-03-25  8:45                     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bknvmh97.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=job@fastly.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).