From: Florian Weimer <fweimer@redhat.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Cc: Wilco Dijkstra via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2] Use C11 atomics instead of atomic_bit_set/bit_test_set
Date: Tue, 13 Sep 2022 12:02:02 +0200 [thread overview]
Message-ID: <87bkrjvbhh.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <AS4PR08MB79018CB83C96DD6E9B6DE82B837E9@AS4PR08MB7901.eurprd08.prod.outlook.com> (Wilco Dijkstra's message of "Tue, 6 Sep 2022 18:41:11 +0000")
* Wilco Dijkstra:
> Hi Florian,
>
> This time with the right patch:
>
> v2: Use relaxed atomics since there is no MO dependence
>
> Replace the 3 uses of atomic_bit_set and atomic_bit_test_set with
> atomic_fetch_or_relaxed.
Patch looks okay. Would you mind adding a sentence to the commit
message at least that this is for use-after-free detection only? Thanks.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Florian
prev parent reply other threads:[~2022-09-13 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 16:35 [PATCH] " Wilco Dijkstra
2022-09-06 12:11 ` Florian Weimer
2022-09-06 16:49 ` Wilco Dijkstra
2022-09-06 16:52 ` Wilco Dijkstra
2022-09-06 17:42 ` Florian Weimer
2022-09-06 18:41 ` [PATCH v2] " Wilco Dijkstra
2022-09-13 10:02 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkrjvbhh.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).