From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C35C93857366 for ; Wed, 27 Jul 2022 15:36:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C35C93857366 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-372-LJQymbXWOi2myTQysPeZ-g-1; Wed, 27 Jul 2022 11:36:54 -0400 X-MC-Unique: LJQymbXWOi2myTQysPeZ-g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BD9662803035; Wed, 27 Jul 2022 15:36:53 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6F2F8909FE; Wed, 27 Jul 2022 15:36:52 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org, "Jason A . Donenfeld" , Carlos O'Donell Subject: Re: [PATCH] stdlib: Tuned down tst-arc4random-thread internal parameters References: <20220727120600.2003708-1-adhemerval.zanella@linaro.org> <878roeeo8t.fsf@oldenburg.str.redhat.com> <66576e3c-acbf-7c02-f47b-6fccb71f756b@linaro.org> <871qu6enhg.fsf@oldenburg.str.redhat.com> <68a46a4e-79eb-068d-0e12-fd466d8b1714@linaro.org> Date: Wed, 27 Jul 2022 17:36:50 +0200 In-Reply-To: <68a46a4e-79eb-068d-0e12-fd466d8b1714@linaro.org> (Adhemerval Zanella Netto's message of "Wed, 27 Jul 2022 10:00:01 -0300") Message-ID: <87bktad0tp.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jul 2022 15:36:59 -0000 * Adhemerval Zanella Netto: >>>> By the way, I think we should switch to the standard arc4random_uniform >>>> implementation that doesn't try to conserve bits. It's cheaper to get a >>>> larger number of bits once instead of obtaining 24 bits first, then 8 >>>> bits. >>> >>> Yeah, it should simpler indeed. But I do not consider this urgent >>> for 2.36. >> >> Well, the standard way probably has more obvious statistical properties >> and is harder to screw up. 8-/ > > Right, do you consider this a blocker? I think I can send a patch to > use a simpler algorithm. I like it because it would minimize risk. It's not a strict blocker. I'm not sure if I'll be able to work on it this week. Maybe I can review a patch. Thanks, Florian