From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9AE5E3857362 for ; Mon, 9 May 2022 12:46:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9AE5E3857362 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-131-T4mPEnpiPtGmcrBMfpnRdQ-1; Mon, 09 May 2022 08:46:56 -0400 X-MC-Unique: T4mPEnpiPtGmcrBMfpnRdQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C3EDC3C138C8; Mon, 9 May 2022 12:46:55 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.246]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 244142024CB7; Mon, 9 May 2022 12:46:53 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Cc: caiyinyu , Adhemerval Zanella , xuchenghua@loongson.cn, joseph_myers@mentor.com Subject: Re: [PATCH v4 04/13] LoongArch: ABI Implementation References: <20220509023010.1250020-1-caiyinyu@loongson.cn> <20220509023010.1250020-5-caiyinyu@loongson.cn> <44834807-c008-45dd-3cea-b3beab266ad8@linaro.org> Date: Mon, 09 May 2022 14:46:52 +0200 In-Reply-To: <44834807-c008-45dd-3cea-b3beab266ad8@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 9 May 2022 09:39:03 -0300") Message-ID: <87bkw6an5v.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 May 2022 12:46:58 -0000 * Adhemerval Zanella via Libc-alpha: >> +/* Return nonzero iff ELF header is compatible with the running host. */ >> +static inline int __attribute_used__ > > I am almost sure that with GNU C11 that we use to build glibc there is no need > to use __attribute_used__. I take you are copy/paste from other ports, but it > would be goot to see if we can clean this up. And __attribute_used__ does more than suppressing the warning: it also emits a copy for access from assembler code (which is not needed here). Thanks, Florian