From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1BBE13858D33 for ; Mon, 2 May 2022 08:34:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1BBE13858D33 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-660-2vJNMOc5NxyZbfkJOZ1wIA-1; Mon, 02 May 2022 04:34:06 -0400 X-MC-Unique: 2vJNMOc5NxyZbfkJOZ1wIA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C1164802819; Mon, 2 May 2022 08:34:05 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA541401E9D; Mon, 2 May 2022 08:34:04 +0000 (UTC) From: Florian Weimer To: Fangrui Song via Libc-alpha Subject: Re: [PATCH] elf: Remove fallback to the start of DT_STRTAB for dladdr References: <20220501215049.2143788-1-maskray@google.com> Date: Mon, 02 May 2022 10:34:03 +0200 In-Reply-To: <20220501215049.2143788-1-maskray@google.com> (Fangrui Song via Libc-alpha's message of "Sun, 1 May 2022 14:50:49 -0700") Message-ID: <87bkwg8hac.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2022 08:34:09 -0000 * Fangrui Song via Libc-alpha: > + /* In the absence of a hash table, as if the object has no symbol. */ Could you rephrase that a bit, maybe =E2=80=9Ctreat the object as if it has= no symbol=E2=80=9D? Rest looks okay to me. Reviewed-by: Florian Weimer Thanks, Florian