From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D44673851C01 for ; Wed, 26 Jan 2022 10:02:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D44673851C01 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-77-u9NfltQ0M_mcdQferX1nPg-1; Wed, 26 Jan 2022 05:02:10 -0500 X-MC-Unique: u9NfltQ0M_mcdQferX1nPg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9AD191006AA7; Wed, 26 Jan 2022 10:02:09 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2C6847A228; Wed, 26 Jan 2022 10:02:07 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Joseph Myers , "H.J. Lu" , libc-alpha@sourceware.org Subject: Re: [PATCH v9 1/3] elf: Add a test for PT_LOAD segments with mixed p_align [BZ #28676] References: <20220121211205.268178-1-hjl.tools@gmail.com> <20220121211205.268178-2-hjl.tools@gmail.com> <812466f3-14b4-e9af-9f97-35707c4bd111@linaro.org> <945e3c11-1285-2227-faa3-ce5e764fc3ff@linaro.org> Date: Wed, 26 Jan 2022 11:02:06 +0100 In-Reply-To: <945e3c11-1285-2227-faa3-ce5e764fc3ff@linaro.org> (Adhemerval Zanella's message of "Tue, 25 Jan 2022 08:33:18 -0300") Message-ID: <87bkzyvmqp.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jan 2022 10:02:18 -0000 * Adhemerval Zanella: > On 24/01/2022 18:21, Joseph Myers wrote: >> On Mon, 24 Jan 2022, Adhemerval Zanella via Libc-alpha wrote: >> >>>> +# Make a copy of tst-p_alignmod-base.so and lower p_align of the first >>>> +# PT_LOAD segment. >>>> +$(objpfx)tst-p_alignmod1.so: $(objpfx)tst-p_alignmod1-edit \ >>>> + $(objpfx)tst-p_alignmod-base.so >>>> + rm -f $@ >>>> + cp $(objpfx)tst-p_alignmod-base.so $@ >>>> + $(test-wrapper-env) $(run-program-env) $(rtld-prefix) \ >>>> + $(objpfx)tst-p_alignmod1-edit $@ >> >> This has broken the testsuite build for all cross-compilation situations >> not running the newly built tests. You can't run a program built with the >> new glibc unless $(run-built-tests) is yes. Either disable everything >> depending on running these programs unless $(run-built-tests) is yes or >> revert the commits adding them (reimplementing the editing in Python using >> only the standard library might be a possibility for the future; building >> the C program for $build wouldn't be a good idea and we'd like to phase >> out the remaining two tests that do use C programs for $build by subsuming >> them in conformtest). >> > > I forgot about this issue and reimplementing using pythong seems a better > approach. I will work on this. Can we revert the test addition in the meantime? It's making validation of other changes complicated. Thanks, Florian