From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id EF32C3858407 for ; Wed, 10 Nov 2021 13:55:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EF32C3858407 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-X1aL1Wm_O16jdK4NnQXUDw-1; Wed, 10 Nov 2021 08:55:42 -0500 X-MC-Unique: X1aL1Wm_O16jdK4NnQXUDw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E55691006AB7; Wed, 10 Nov 2021 13:55:35 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A65035D6B1; Wed, 10 Nov 2021 13:55:34 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard Subject: Re: [PATCH v5 02/22] elf: Add audit tests for modules with TLSDESC References: <20211109183347.2943786-1-adhemerval.zanella@linaro.org> <20211109183347.2943786-3-adhemerval.zanella@linaro.org> Date: Wed, 10 Nov 2021 14:55:32 +0100 In-Reply-To: <20211109183347.2943786-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Tue, 9 Nov 2021 15:33:27 -0300") Message-ID: <87bl2s5d4b.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2021 13:55:46 -0000 * Adhemerval Zanella: > diff --git a/elf/Makefile b/elf/Makefile > index bad18f2d11..bd1a0f79b4 100644 > --- a/elf/Makefile > +++ b/elf/Makefile > @@ -384,6 +384,20 @@ modules-names += tst-gnu2-tls1mod > $(objpfx)tst-gnu2-tls1: $(objpfx)tst-gnu2-tls1mod.so > tst-gnu2-tls1mod.so-no-z-defs = yes > CFLAGS-tst-gnu2-tls1mod.c += -mtls-dialect=gnu2 > + > +tests += tst-audit-tlsdesc tst-audit-tlsdesc-dlopen > +modules-names += tst-auditmod-tlsdesc1 tst-auditmod-tlsdesc2 tst-audit-tlsdesc-audit > +$(objpfx)tst-audit-tlsdesc: $(objpfx)tst-auditmod-tlsdesc1.so \ > + $(objpfx)tst-auditmod-tlsdesc2.so \ > + $(shared-thread-library) > +CFLAGS-tst-auditmod-tlsdesc1.c += -mtls-dialect=gnu2 > +CFLAGS-tst-auditmod-tlsdesc2.c += -mtls-dialect=gnu2 Do we need to check have-mtls-dialect-gnu2 here? > diff --git a/elf/tst-audit-tlsdesc-audit.c b/elf/tst-audit-tlsdesc-audit.c > new file mode 100644 > index 0000000000..53993830c9 > --- /dev/null > +++ b/elf/tst-audit-tlsdesc-audit.c > +unsigned int > +la_version (unsigned int version) > +{ > + return version; > +} Why not LAV_CURRENT? We should lead by good example. Thanks, Florian