From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 20963384F003 for ; Tue, 13 Jul 2021 15:58:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 20963384F003 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-428-6jFBkmY4NXq2ODVIwxT26A-1; Tue, 13 Jul 2021 11:58:00 -0400 X-MC-Unique: 6jFBkmY4NXq2ODVIwxT26A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3D6018D6A25; Tue, 13 Jul 2021 15:57:59 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-59.ams2.redhat.com [10.36.113.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0256160CCC; Tue, 13 Jul 2021 15:57:58 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH] posix: Ignore non opened files on tst-spawn5 References: <20210713141749.2717687-1-adhemerval.zanella@linaro.org> Date: Tue, 13 Jul 2021 17:57:57 +0200 In-Reply-To: <20210713141749.2717687-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 13 Jul 2021 11:17:49 -0300") Message-ID: <87bl76i4u2.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 15:58:03 -0000 * Adhemerval Zanella via Libc-alpha: > The make program might open a pipe for its job server, which triggers > an invalid check on the spawned process. This patch now passes the > lowest file descriptor as ithe first argument, so only the range > that was actually opened is checked. > > Checked on x86_64-linux-gnu and i686-linux-gnu and centos7 (which > triggers the issue). It fixes the test failures on my systems, thanks. Florian