public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v7 3/4] io: Add closefrom [BZ #10353]
Date: Wed, 07 Jul 2021 12:39:56 +0200	[thread overview]
Message-ID: <87bl7e9zlv.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210706145839.1658623-4-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 6 Jul 2021 11:58:38 -0300")

* Adhemerval Zanella via Libc-alpha:

> diff --git a/manual/llio.texi b/manual/llio.texi
> index ea6d34dd5a..d1ed9e6490 100644
> --- a/manual/llio.texi
> +++ b/manual/llio.texi
> @@ -332,6 +332,16 @@ The kernel does not implement the required functionality.
>  @end table
>  @end deftypefun
>  
> +@deftypefun void closefrom (int @var{lowfd})
> +@standards{GNU, unistd.h}
> +@safety{@prelim{}@mtsafe{}@assafe{}@acsafe{@acsfd{}}}
> +
> +The function @code{closefrom} closes all file descriptors larger than or equal
> +to @var{lowfd} then @var{lowfd}.  This function is similar to call
> +@code{close} applied to the specified file descriptor range.
> +
> +Already closed file descriptors are ignored.
> +@end deftypefun

Suggest: “This function is similar to calling  @code{close} for all open
file descriptors not less than @var{lowfd}.”

Code changes look okay to me.

Thanks,
Florian


  reply	other threads:[~2021-07-07 10:40 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 14:58 [PATCH v7 0/4] Add close_range, closefrom, and posix_spawn_file_actions_closefrom_np Adhemerval Zanella
2021-07-06 14:58 ` [PATCH v7 1/4] support: Add support_stack_alloc Adhemerval Zanella
2021-07-07 10:17   ` Florian Weimer
2021-07-07 12:17     ` Adhemerval Zanella
2021-07-07 17:15       ` Florian Weimer
2021-07-07 17:26         ` Adhemerval Zanella
2021-07-08  5:43           ` Florian Weimer
2021-07-08 12:33             ` Adhemerval Zanella
2021-07-06 14:58 ` [PATCH v7 2/4] linux: Add close_range Adhemerval Zanella
2021-07-07 10:22   ` Florian Weimer
2021-07-07 12:51     ` Adhemerval Zanella
2021-07-07 12:53       ` Florian Weimer
2021-07-06 14:58 ` [PATCH v7 3/4] io: Add closefrom [BZ #10353] Adhemerval Zanella
2021-07-07 10:39   ` Florian Weimer [this message]
2021-07-07 12:55     ` Adhemerval Zanella
2021-07-06 14:58 ` [PATCH v7 4/4] posix: Add posix_spawn_file_actions_addclosefrom_np Adhemerval Zanella
2021-07-08 14:34   ` Florian Weimer
2021-07-08 16:12     ` Adhemerval Zanella
2021-07-08 21:54       ` H.J. Lu
2021-07-08 23:23         ` Adhemerval Zanella
2021-07-06 19:28 ` [PATCH v7 0/4] Add close_range, closefrom, and posix_spawn_file_actions_closefrom_np DJ Delorie
2021-07-06 19:33   ` Adhemerval Zanella
2021-07-06 19:38     ` Adhemerval Zanella
2021-07-06 19:47       ` DJ Delorie
2021-07-06 20:23         ` Adhemerval Zanella
2021-07-06 20:30           ` DJ Delorie
2021-07-06 21:33           ` DJ Delorie
2021-07-07  2:14             ` Adhemerval Zanella
2021-07-07  2:26               ` DJ Delorie
2021-07-06 19:42     ` DJ Delorie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl7e9zlv.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).