From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 46D323AA7C98 for ; Thu, 24 Jun 2021 08:15:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 46D323AA7C98 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-387-NjH1MY4BOHm_4lWqRzUfMg-1; Thu, 24 Jun 2021 04:15:57 -0400 X-MC-Unique: NjH1MY4BOHm_4lWqRzUfMg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 96184A40C4; Thu, 24 Jun 2021 08:15:56 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-228.ams2.redhat.com [10.36.112.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCC961000358; Thu, 24 Jun 2021 08:15:55 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v4 1/4] posix: Consolidate fork implementation References: <20210623184354.395316-1-adhemerval.zanella@linaro.org> <20210623184354.395316-2-adhemerval.zanella@linaro.org> Date: Thu, 24 Jun 2021 10:15:53 +0200 In-Reply-To: <20210623184354.395316-2-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Wed, 23 Jun 2021 15:43:51 -0300") Message-ID: <87bl7vn0ee.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jun 2021 08:16:00 -0000 * Adhemerval Zanella via Libc-alpha: > diff --git a/include/unistd.h b/include/unistd.h > index 34872d8b41..d554d44edb 100644 > --- a/include/unistd.h > +++ b/include/unistd.h > @@ -140,6 +140,10 @@ extern __pid_t __vfork (void); > libc_hidden_proto (__vfork) > extern int __ttyname_r (int __fd, char *__buf, size_t __buflen); > libc_hidden_proto (__ttyname_r) > +extern int __ttyname_r (int __fd, char *__buf, size_t __buflen) > + attribute_hidden; Duplicate declaration of __ttyname_r. Merge error? Rest looks okay to me. Thanks, Florian