From: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
To: "Lucas A. M. Magalhaes" <lamm@linux.ibm.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v2] powerpc: Optimized memmove for POWER10
Date: Fri, 30 Apr 2021 18:18:24 -0300 [thread overview]
Message-ID: <87bl9vmpy7.fsf@linux.ibm.com> (raw)
In-Reply-To: <20210429204231.1486973-1-lamm@linux.ibm.com>
Pedantic comment in the subject: I was explicit this affects powerpc64le.
"Lucas A. M. Magalhaes via Libc-alpha" <libc-alpha@sourceware.org> writes:
> --- a/sysdeps/powerpc/powerpc64/multiarch/Makefile
> +++ b/sysdeps/powerpc/powerpc64/multiarch/Makefile
> @@ -24,7 +24,8 @@ sysdep_routines += memcpy-power8-cached memcpy-power7 memcpy-a2 memcpy-power6 \
> stpncpy-power8 stpncpy-power7 stpncpy-ppc64 \
> strcmp-power8 strcmp-power7 strcmp-ppc64 \
> strcat-power8 strcat-power7 strcat-ppc64 \
> - memmove-power7 memmove-ppc64 wordcopy-ppc64 bcopy-ppc64 \
> + memmove-power7 memmove-ppc64 \
> + wordcopy-ppc64 bcopy-ppc64 \
I suspect this hunk got in this version of the patch by mistake.
Removed.
> @@ -34,7 +35,7 @@ sysdep_routines += memcpy-power8-cached memcpy-power7 memcpy-a2 memcpy-power6 \
> ifneq (,$(filter %le,$(config-machine)))
> sysdep_routines += strcmp-power9 strncmp-power9 strcpy-power9 stpcpy-power9 \
> rawmemchr-power9 strlen-power9 strncpy-power9 stpncpy-power9 \
> - strlen-power10
> + memmove-power10 strlen-power10
The list of files is not ordered, but I try to keep it ordered.
Fixed.
Pushed as dd59655e9371af86043b97e38953f43bd9496699.
Thanks!
--
Tulio Magno
next prev parent reply other threads:[~2021-04-30 21:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 20:42 Lucas A. M. Magalhaes
2021-04-29 21:13 ` Matheus Castanho
2021-04-29 21:24 ` Raphael M Zinsly
2021-04-30 12:56 ` Raoni Fassina Firmino
2021-04-30 21:18 ` Tulio Magno Quites Machado Filho [this message]
2021-05-06 14:50 ` Andreas Schwab
2021-05-06 14:57 ` Florian Weimer
2021-05-06 15:55 ` Lucas A. M. Magalhaes
2021-05-06 16:04 ` Andreas Schwab
2021-05-06 18:29 ` Tulio Magno Quites Machado Filho
2021-05-06 18:34 ` Andreas Schwab
2021-05-06 18:53 ` Tulio Magno Quites Machado Filho
2021-05-06 19:51 ` Andreas Schwab
2021-05-06 15:03 ` Andreas Schwab
2021-05-06 16:35 ` Lucas A. M. Magalhaes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl9vmpy7.fsf@linux.ibm.com \
--to=tuliom@linux.ibm.com \
--cc=lamm@linux.ibm.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).