From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id B9190386F038
 for <libc-alpha@sourceware.org>; Fri, 19 Mar 2021 20:36:09 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B9190386F038
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de
Received: from [172.17.203.2] (port=48503 helo=deneb.enyo.de)
 by albireo.enyo.de ([172.17.140.2]) with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 id 1lNLqq-0005Vt-DI; Fri, 19 Mar 2021 20:36:08 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.92)
 (envelope-from <fw@deneb.enyo.de>)
 id 1lNLqq-00065o-9R; Fri, 19 Mar 2021 21:36:08 +0100
From: Florian Weimer <fw@deneb.enyo.de>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 01/14] Add OTHER_SHLIB_COMPAT
References: <20210319202914.2475530-1-adhemerval.zanella@linaro.org>
 <20210319202914.2475530-2-adhemerval.zanella@linaro.org>
Date: Fri, 19 Mar 2021 21:36:08 +0100
In-Reply-To: <20210319202914.2475530-2-adhemerval.zanella@linaro.org>
 (Adhemerval Zanella via Libc-alpha's message of "Fri, 19 Mar 2021
 17:29:01 -0300")
Message-ID: <87blbenao7.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Mar 2021 20:36:11 -0000

* Adhemerval Zanella via Libc-alpha:

> +/* Like SHLIB_COMPAT, but can check versions in other libraries.  It is
> +   not always false outside for !IS_IN (LIB).  */
> +#define OTHER_SHLIB_COMPAT(lib, introduced, obsoleted)	\
> +  _OTHER_SHLIB_COMPAT (lib, introduced, obsoleted)
> +#define _OTHER_SHLIB_COMPAT(lib, introduced, obsoleted)			\
> +  (!(ABI_##lib##_##obsoleted - 0)					\
> +   || ((ABI_##lib##_##introduced - 0) < (ABI_##lib##_##obsoleted - 0)))
> +

Maybe: =E2=80=9CLike SHLIB_COMPAT, but it can check versions in other
libraries.  It is not always false for !IS_IN (LIB).=E2=80=9D

Looks okay otherwise.