From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 2/4] Linux: Add close_range
Date: Wed, 23 Dec 2020 15:17:38 +0100 [thread overview]
Message-ID: <87blekr4hp.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <7523b3c3-36a5-1cb3-3961-362d1450ca47@linaro.org> (Adhemerval Zanella's message of "Wed, 23 Dec 2020 11:07:36 -0300")
* Adhemerval Zanella:
>>> +_Noreturn static int
>>> +close_range_unshare_test_fn (void *arg)
>>> +{
>>> + int lowfd = (int) ((uintptr_t) arg);
>>> + close_range_test_common (lowfd, CLOSE_RANGE_UNSHARE);
>>> + exit (EXIT_SUCCESS);
>>> +}
>>
>> I think you could check here against the original descriptor set, to
>> ensure that CLOSE_RANGE_UNSHARE still closes everything.
>
> But close_range_test_common already does it.
Okay, that's probably enough.
Thanks,
Florian
--
Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill
next prev parent reply other threads:[~2020-12-23 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 21:27 [PATCH 1/4] support: Add xclone Adhemerval Zanella
2020-12-22 21:27 ` [PATCH v2 2/4] Linux: Add close_range Adhemerval Zanella
2020-12-23 12:22 ` Florian Weimer
2020-12-23 14:07 ` Adhemerval Zanella
2020-12-23 14:17 ` Florian Weimer [this message]
2020-12-22 21:27 ` [PATCH v2 3/4] io: Add closefrom [BZ #10353] Adhemerval Zanella
2020-12-23 13:28 ` Florian Weimer
2020-12-23 14:51 ` Adhemerval Zanella
2020-12-22 21:27 ` [PATCH v2 4/4] posix: Add posix_spawn_file_actions_closefrom Adhemerval Zanella
2020-12-23 14:27 ` Florian Weimer
2020-12-23 16:18 ` Adhemerval Zanella
2020-12-23 11:35 ` [PATCH 1/4] support: Add xclone Florian Weimer
2020-12-23 13:13 ` Adhemerval Zanella
2020-12-23 12:20 ` Christian Brauner
2020-12-23 13:05 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blekr4hp.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).