From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from camel.birch.relay.mailchannels.net (camel.birch.relay.mailchannels.net [23.83.209.29]) by sourceware.org (Postfix) with ESMTPS id 3B710386F826 for ; Thu, 19 Nov 2020 17:31:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3B710386F826 X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C3C8B180FEC; Thu, 19 Nov 2020 17:31:57 +0000 (UTC) Received: from pdx1-sub0-mail-a18.g.dreamhost.com (100-96-21-92.trex.outbound.svc.cluster.local [100.96.21.92]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 12D6318088B; Thu, 19 Nov 2020 17:31:57 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|tuliom@ascii.art.br Received: from pdx1-sub0-mail-a18.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.10); Thu, 19 Nov 2020 17:31:57 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|tuliom@ascii.art.br X-MailChannels-Auth-Id: dreamhost X-Invention-Well-Made: 134577690e372e42_1605807117332_2374940254 X-MC-Loop-Signature: 1605807117332:4225357878 X-MC-Ingress-Time: 1605807117332 Received: from pdx1-sub0-mail-a18.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTP id C5C1D7F84C; Thu, 19 Nov 2020 09:31:56 -0800 (PST) Received: from ascii.art.br (unknown [168.195.65.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tuliom@ascii.art.br) by pdx1-sub0-mail-a18.g.dreamhost.com (Postfix) with ESMTPSA id 0991C7F84F; Thu, 19 Nov 2020 09:31:55 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a18 From: Tulio Magno Quites Machado Filho To: Adhemerval Zanella , libc-alpha@sourceware.org Subject: Re: [PATCH 26/28] linux: Consolidate brk implementation In-Reply-To: <20201118195552.2687336-27-adhemerval.zanella@linaro.org> References: <20201118195552.2687336-1-adhemerval.zanella@linaro.org> <20201118195552.2687336-27-adhemerval.zanella@linaro.org> User-Agent: Notmuch/0.29.1 (http://notmuchmail.org) Emacs/26.3 (x86_64-redhat-linux-gnu) Date: Thu, 19 Nov 2020 14:31:53 -0300 Message-ID: <87blftdzhy.fsf@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2020 17:32:01 -0000 Adhemerval Zanella via Libc-alpha writes: > diff --git a/sysdeps/unix/sysv/linux/pipe.c b/sysdeps/unix/sysv/linux/pipe.c > index 0ea6ca5842..bc105ba6a7 100644 > --- a/sysdeps/unix/sysv/linux/pipe.c > +++ b/sysdeps/unix/sysv/linux/pipe.c > @@ -26,7 +26,7 @@ > int > __pipe (int __pipedes[2]) > -{ > - return INLINE_SYSCALL_CALL (pipe2, __pipedes, 0); > + return INLINE_SYSCALL_CALL (pipe2, (int *) __pipedes, 0); Oops. I think this part was intended for the previous patch. This patch LGTM after removing this. Reviewed-by: Tulio Magno Quites Machado Filho -- Tulio Magno