From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 1D1BD3857C67 for ; Wed, 21 Oct 2020 05:21:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1D1BD3857C67 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-0bXjZdpJPCm8e1GkcMOz8g-1; Wed, 21 Oct 2020 01:21:26 -0400 X-MC-Unique: 0bXjZdpJPCm8e1GkcMOz8g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BABBC8030D5; Wed, 21 Oct 2020 05:21:25 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-83.ams2.redhat.com [10.36.112.83]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DCB5B60CCC; Wed, 21 Oct 2020 05:21:24 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Cc: Adhemerval Zanella , Alistair Francis Subject: __xstat et al. as compat symbols (was: Re: [PATCH 14/16] linux: Move {f}xstat{at} to compat symbols) References: <20200723194641.1949404-1-adhemerval.zanella@linaro.org> <20200723194641.1949404-15-adhemerval.zanella@linaro.org> Date: Wed, 21 Oct 2020 07:21:23 +0200 In-Reply-To: <20200723194641.1949404-15-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Thu, 23 Jul 2020 16:46:39 -0300") Message-ID: <87blgw2lyk.fsf_-_@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2020 05:21:30 -0000 * Adhemerval Zanella via Libc-alpha: > diff --git a/sysdeps/unix/sysv/linux/alpha/fxstat64.c b/sysdeps/unix/sysv/linux/alpha/fxstat64.c > index 9d6b8eca32..bcfb55050c 100644 > --- a/sysdeps/unix/sysv/linux/alpha/fxstat64.c > +++ b/sysdeps/unix/sysv/linux/alpha/fxstat64.c > @@ -22,9 +22,11 @@ > #include > #include > #include > +#include > > /* Get information about the file NAME in BUF. */ > int > +attribute_compat_text_section > __fxstat64 (int vers, int fd, struct stat64 *buf) > { > switch (vers) > @@ -42,4 +44,12 @@ __fxstat64 (int vers, int fd, struct stat64 *buf) > } > } > } > -strong_alias (__fxstat64, __fxstat); > + > +#if SHLIB_COMPAT(libc, GLIBC_2_0, GLIBC_2_33) > +strong_alias (__fxstat64, __fxstat_compat) > +compat_symbol (libc, __fxstat_compat, __fxstat, GLIBC_2_0); > +#endif > + > +#if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_33) > +compat_symbol (libc, __fxstat64, __fxstat64, GLIBC_2_1); > +#endif This change breaks a lot of static libraries out there. Do we really want to do this immediately, or should we just stop using these symbols from libc_nonshared.a, and defer the compat symbol treatment to a future glibc version? Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill