From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fw@deneb.enyo.de>
Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21])
 by sourceware.org (Postfix) with ESMTPS id F3BC13898518
 for <libc-alpha@sourceware.org>; Thu, 30 Apr 2020 13:54:42 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F3BC13898518
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=deneb.enyo.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de
Received: from [172.17.203.2] (helo=deneb.enyo.de)
 by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
 id 1jU9eD-000891-6h; Thu, 30 Apr 2020 13:54:41 +0000
Received: from fw by deneb.enyo.de with local (Exim 4.92)
 (envelope-from <fw@deneb.enyo.de>)
 id 1jU9eD-0008Li-3t; Thu, 30 Apr 2020 15:54:41 +0200
From: Florian Weimer <fw@deneb.enyo.de>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>,
 "H.J. Lu" <hjl.tools@gmail.com>
Subject: Re: V2 [PATCH] Add a C wrapper for prctl [BZ #25896]
References: <20200429205217.2435607-1-hjl.tools@gmail.com>
 <87wo5xa0yt.fsf@mid.deneb.enyo.de> <20200430130333.GA254612@gmail.com>
 <87h7x1gkfg.fsf@igel.home> <87mu6t84yg.fsf@mid.deneb.enyo.de>
 <87d07pgjz0.fsf@igel.home>
Date: Thu, 30 Apr 2020 15:54:41 +0200
In-Reply-To: <87d07pgjz0.fsf@igel.home> (Andreas Schwab's message of "Thu, 30
 Apr 2020 15:51:31 +0200")
Message-ID: <87bln984f2.fsf@mid.deneb.enyo.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-23.6 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, SPF_HELO_NONE,
 SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Apr 2020 13:54:44 -0000

* Andreas Schwab:

> On Apr 30 2020, Florian Weimer wrote:
>
>> * Andreas Schwab:
>>
>>> On Apr 30 2020, H.J. Lu via Libc-alpha wrote:
>>>
>>>> diff --git a/include/sys/prctl.h b/include/sys/prctl.h
>>>> index 0920ed642b..1a74d83879 100644
>>>> --- a/include/sys/prctl.h
>>>> +++ b/include/sys/prctl.h
>>>> @@ -4,6 +4,8 @@
>>>>  # ifndef _ISOMAC
>>>>  
>>>>  extern int __prctl (int __option, ...);
>>>> +libc_hidden_proto (__prctl)
>>>> +libc_hidden_proto (prctl)
>>>
>>> Why do you need the hidden alias for prctl?  All references inside
>>> libc.so should use __prctl.
>>
>> Right.  I want to clean this up in a separate patch.
>
> ??? Why adding it in the first place?

I thought pthread_getname was linked into libc, but looks like it's in
libpthread, so its use of prctl (not __prctl) should be fine.

H.J., what happens if you drop the hidden alias for prctl?