From: Florian Weimer <fweimer@redhat.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] [GLIBC RFC] clone3: add CLONE3_RESET_SIGHAND
Date: Wed, 09 Oct 2019 11:04:00 -0000 [thread overview]
Message-ID: <87bluq18po.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20191009104830.w2fkr4m3lrkfowxq@wittgenstein> (Christian Brauner's message of "Wed, 9 Oct 2019 12:48:31 +0200")
* Christian Brauner:
> I've been thinking about two things how to do this:
> - mask the flags that the kernel does not support
That doesn't look fully backwards-compatible to me. The argument isn't
currently read/write, is it? It would work for us though.
> - add another argument to struct clone_args that is "known_flags"
> when the syscall returns it'll be set to all the flags this kernel
> knows about
This needs some sort of protocol to detect whether the argument was
updated. I suppose we could define CLONE3_INITIALLY_SUPPORTED_FLAGS
with all the flag bits currently supported and tell developers to
initialize struct clone_args with:
.known_flags = CLONE3_INITIALLY_SUPPORTED_FLAGS,
Then the result would be correct whether or not known_flags is supported
by the kernel or not. This too would work fine for glibc internal use.
By theway, I don't think we have a good userspace API story for
extensible *output* arguments yet. Every system call does things a
little bit differently there.
Thanks,
Florian
next prev parent reply other threads:[~2019-10-09 11:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 13:44 Christian Brauner
2019-10-08 14:14 ` Christian Brauner
2019-10-08 14:20 ` Adhemerval Zanella
2019-10-09 10:48 ` Christian Brauner
2019-10-09 11:04 ` Florian Weimer [this message]
2019-10-09 11:12 ` Christian Brauner
2019-10-09 11:56 ` Florian Weimer
2019-10-09 11:58 ` Christian Brauner
2019-10-09 12:01 ` Florian Weimer
2019-10-09 13:33 ` Christian Brauner
2019-10-10 10:51 ` Christian Brauner
2019-10-10 14:49 ` Florian Weimer
2019-10-11 10:47 ` Christian Brauner
2019-10-09 11:14 ` Dmitry V. Levin
2019-12-04 13:16 ` clone3: CLONE_CLEAR_SIGHAND v5.5 Christian Brauner
2019-12-04 13:45 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bluq18po.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=christian.brauner@ubuntu.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).