public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fw@deneb.enyo.de>
To: Joseph Myers <joseph@codesourcery.com>
Cc: Carlos O'Donell <carlos@redhat.com>,
	 Andreas Schwab <schwab@linux-m68k.org>,
	 <libc-alpha@sourceware.org>,
	 "Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH] <bits/syscall.h>: Use an arch-independent system call list on Linux
Date: Thu, 24 Aug 2017 18:49:00 -0000	[thread overview]
Message-ID: <87bmn4u7iy.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1708241508030.8746@digraph.polyomino.org.uk> (Joseph Myers's message of "Thu, 24 Aug 2017 15:15:18 +0000")

* Joseph Myers:

> I do not object to bounding the SYS_* API exported by glibc to a set of 
> system calls known to that glibc version.
>
> I do object to having a test we know will fail when someone builds glibc 
> with a newer set of kernel headers than that version of glibc.  That is, I 
> think the test should allow extra __NR_* if the kernel headers have a 
> newer (major.minor) version number than the kernel version listed in 
> syscall-names.list.  That way, the test is still effective in development 
> as long as people update the kernel number when adding syscalls to the 
> file or doing other new-kernel-version updates, without causing spurious 
> failures for people building past release versions / branches of glibc.

Hmm.  The way the patch currently works, a missing built-in system
call name is actually a user-visible bug because they won't get the
SYS_* macro they expect (based on the kernel headers).  This is why I
made it a test failure.

If we don't want that, I need to resurrect the old magic list
generation and use its results to augment the built-in list.  The test
can remain as-is, but it will no longer fail.

A compromise would be to assume that for mixed-mode architectures
(e.g., i386/x86-64/x32), the set of missing system calls is the same
across all architectures, then we could still leave out the
complicated list generation logic.

> I'd expect LC_ALL=C to have to be set when running the various awk scripts 
> (at least those depending in any way on the ordering of the syscall list).

Right, that needs to be fixed.

  parent reply	other threads:[~2017-08-24 18:49 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 19:40 Florian Weimer
2017-04-06  8:00 ` Andreas Schwab
2017-04-06  8:52   ` Florian Weimer
2017-04-06  9:03     ` Andreas Schwab
2017-04-06  9:47       ` Florian Weimer
2017-04-06 10:07         ` Andreas Schwab
2017-04-06 10:12           ` Florian Weimer
2017-04-06 12:29             ` Andreas Schwab
2017-04-06 12:32               ` Florian Weimer
2017-04-06 12:49                 ` Andreas Schwab
2017-04-06 13:24                   ` Florian Weimer
2017-04-06 13:44                     ` Andreas Schwab
2017-04-06 14:22                       ` Florian Weimer
2017-04-06 14:37                         ` Dmitry V. Levin
2017-04-21 10:06                           ` Florian Weimer
2017-04-21 12:27                             ` Andreas Schwab
2017-04-21 12:37                               ` Florian Weimer
2017-04-21 18:31                               ` Carlos O'Donell
2017-04-21 18:02                                 ` Andreas Schwab
2017-04-21 18:46                                   ` Florian Weimer
2017-04-21 19:08                                     ` Andreas Schwab
2017-04-21 19:15                                       ` Florian Weimer
2017-04-21 19:34                                         ` Andreas Schwab
2017-04-21 19:37                                           ` Florian Weimer
2017-04-21 19:40                                             ` Andreas Schwab
2017-04-21 19:57                                               ` Florian Weimer
2017-04-22  9:38                                                 ` Andreas Schwab
2017-04-22 11:59                                                   ` Florian Weimer
2017-04-22 13:45                                                     ` Andreas Schwab
2017-04-22 14:22                                                       ` Florian Weimer
2017-04-22 15:08                                                         ` Andreas Schwab
2017-04-22 15:27                                                           ` Florian Weimer
2017-04-22 15:37                                                             ` Andreas Schwab
2017-04-22 15:51                                                               ` Florian Weimer
2017-04-22 17:27                                                                 ` Andreas Schwab
2017-08-24 14:35                                     ` Carlos O'Donell
2017-08-24 15:15                                       ` Joseph Myers
2017-08-24 16:08                                         ` Carlos O'Donell
2017-08-24 18:49                                         ` Florian Weimer [this message]
2017-08-24 20:28                                           ` Joseph Myers
2017-08-25 14:30                                             ` Florian Weimer
2017-08-25 15:40                                               ` Joseph Myers
2017-08-25 15:57                                                 ` Florian Weimer
2017-08-28 11:36                                                   ` Joseph Myers
2017-08-28 12:35                                                     ` Florian Weimer
2017-08-28 12:43                                                       ` Joseph Myers
2017-04-23  0:35                                 ` synchronizing kernel UAPI and libc headers Dmitry V. Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmn4u7iy.fsf@mid.deneb.enyo.de \
    --to=fw@deneb.enyo.de \
    --cc=carlos@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=ldv@altlinux.org \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).