From: "Tulio Magno Quites Machado Filho" <tuliom@linux.vnet.ibm.com>
To: Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCHv2] powerpc: strcasestr optmization for power8
Date: Mon, 18 Apr 2016 21:27:00 -0000 [thread overview]
Message-ID: <87bn5638wg.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <1459937731-21341-1-git-send-email-raji@linux.vnet.ibm.com>
Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com> writes:
> This patch optimizes strcasestr function for power >= 8 systems. The average
> improvement of this optimization is ~40% and compares 16 bytes at a time
> using vector instructions. This patch is tested on powerpc64 and powerpc64le.
>
> 2016-04-16 Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
>
> * sysdeps/powerpc/locale-defines.sym: Add new macros.
> * sysdeps/powerpc/powerpc64/multiarch/Makefile: Add strcasestr().
Please, mention which variable you changed, e.g.:
* sysdeps/powerpc/powerpc64/multiarch/Makefile (sysdep_routines):
Add strcasestr().
> * sysdeps/powerpc/powerpc64/multiarch/ifunc-impl-list.c: Likewise.
> * sysdeps/powerpc/powerpc64/multiarch/strcasestr-power8.S: New file.
> * sysdeps/powerpc/powerpc64/multiarch/strcasestr-ppc64.c: New file.
> * sysdeps/powerpc/powerpc64/multiarch/strcasestr.c: New file.
> * sysdeps/powerpc/powerpc64/power8/Makefile: New file.
Likewise
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strcasestr-power8.S b/sysdeps/powerpc/powerpc64/multiarch/strcasestr-power8.S
>...
> +/* The following definitions are used in strcasestr optimization. */
> +
> +/* strlen is used to calculate len of r4. */
> +#define STRLEN __strlen_power7
We can now move this to power8.
> diff --git a/sysdeps/powerpc/powerpc64/power8/strcasestr.S b/sysdeps/powerpc/powerpc64/power8/strcasestr.S
> new file mode 100644
> index 0000000..d270d4c
> ...
> + std r28, -32(r1) /* Save callers register r28. */
> + std r27, -40(r1) /* Save callers register r27. */
This should have tabs ------^
It also appears in other lines of this file.
LGTM.
--
Tulio Magno
prev parent reply other threads:[~2016-04-18 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 10:17 Rajalakshmi Srinivasaraghavan
2016-04-18 21:27 ` Tulio Magno Quites Machado Filho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn5638wg.fsf@linux.vnet.ibm.com \
--to=tuliom@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=raji@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).