public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Florian Weimer via Libc-alpha <libc-alpha@sourceware.org>,
	 Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Subject: Re: _rtld_global, _rtld_global_ro (and local aliases) as an optimization
Date: Wed, 07 Jun 2023 11:37:01 +0200	[thread overview]
Message-ID: <87cz277gw2.fsf@oldenburg3.str.redhat.com> (raw)
In-Reply-To: <mvm35337hxc.fsf@suse.de> (Andreas Schwab's message of "Wed, 07 Jun 2023 11:14:39 +0200")

* Andreas Schwab:

> On Jun 07 2023, Florian Weimer via Libc-alpha wrote:
>
>> As a concrete example, we could turn GLRO(dl_dso_sort_algo) into
>>
>> static int dso_sort_algo;
>>
>> in elf/dl-sort-maps.c because it's not used outside the file.
>
> I think it was just a mistake to put it there initially.  None of the
> definitions related to the DSO sort algo (except _dl_sort_maps_init)
> need to be visible outside that file.

We have more cases that are somewhat similar, where we could use an
extern attribute_hidden variable instead of a struct member.  What about
those?

Thanks,
Florian


  reply	other threads:[~2023-06-07  9:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 12:14 Florian Weimer
2023-06-06 19:30 ` Adhemerval Zanella Netto
2023-06-07  8:57   ` Florian Weimer
2023-06-07  9:14     ` Andreas Schwab
2023-06-07  9:37       ` Florian Weimer [this message]
2023-06-07 12:08         ` Adhemerval Zanella Netto
2023-06-07 12:21           ` Florian Weimer
2023-06-07 12:40             ` Adhemerval Zanella Netto
2023-06-07 12:56               ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz277gw2.fsf@oldenburg3.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).