From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Cc: Siddhesh Poyarekar <siddhesh@redhat.com>,
Joe Simmons-Talbott <josimmon@redhat.com>
Subject: [PATCH] stdlib: Avoid undefined behavior in stdlib/tst-labs
Date: Tue, 16 May 2023 23:35:36 +0200 [thread overview]
Message-ID: <87cz303qon.fsf@oldenburg.str.redhat.com> (raw)
The last loop could attempt to overflow beyond INT_MAX on 32-bit
architectures.
Also switch to GNU style.
---
stdlib/tst-labs.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/stdlib/tst-labs.c b/stdlib/tst-labs.c
index 92b456745a..a8d2381f87 100644
--- a/stdlib/tst-labs.c
+++ b/stdlib/tst-labs.c
@@ -25,25 +25,26 @@
static int do_test (void)
{
- long i;
+ long int i;
- TEST_COMPARE(labs(LONG_MAX), LONG_MAX);
- TEST_COMPARE(labs(LONG_MIN + 1), LONG_MAX);
- TEST_COMPARE(labs(-1), 1);
- TEST_COMPARE(labs(0), 0);
- TEST_COMPARE(labs(1), 1);
+ TEST_COMPARE (labs (LONG_MAX), LONG_MAX);
+ TEST_COMPARE (labs (LONG_MIN + 1), LONG_MAX);
+ TEST_COMPARE (labs (-1), 1);
+ TEST_COMPARE (labs (0), 0);
+ TEST_COMPARE (labs (1), 1);
for (i = LONG_MIN + 1; i < LONG_MIN + INT_MAX; i += LARGE_PRIME)
- TEST_COMPARE(labs(i), -i);
+ TEST_COMPARE (labs (i), -i);
- for (i = LONG_MAX - INT_MAX; i < LONG_MAX - LARGE_PRIME; i += LARGE_PRIME)
- TEST_COMPARE(labs(i), i);
+ for (i = LONG_MAX - INT_MAX; i < LONG_MAX - LARGE_PRIME;
+ i += LARGE_PRIME)
+ TEST_COMPARE (labs (i), i);
for (i = INT_MIN + 1; i < 0; i += LARGE_PRIME)
- TEST_COMPARE(labs(i), -i);
+ TEST_COMPARE (labs (i), -i);
- for (i = 0; i < INT_MAX; i += LARGE_PRIME)
- TEST_COMPARE(labs(i), i);
+ for (i = 0; i <= INT_MAX - LARGE_PRIME; i += LARGE_PRIME)
+ TEST_COMPARE (labs (i), i);
return EXIT_SUCCESS;
}
base-commit: 641c4c2b7eb80e2cb2121b1c31096158091a6419
next reply other threads:[~2023-05-16 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 21:35 Florian Weimer [this message]
2023-05-17 0:19 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz303qon.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=josimmon@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).