From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 852173954C59 for ; Tue, 3 May 2022 16:57:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 852173954C59 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-625-cSyClnq-OTSBj_awuOiO_A-1; Tue, 03 May 2022 12:57:17 -0400 X-MC-Unique: cSyClnq-OTSBj_awuOiO_A-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 698E918A658D; Tue, 3 May 2022 16:57:16 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.113]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6118F4679FF; Tue, 3 May 2022 16:57:13 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: GNU C Library Subject: Re: [PATCH 1/5] Linux: Implement a useful version of _startup_fatal References: <7a6a51b346a81484046ba392a9854a88568a92aa.1651518694.git.fweimer@redhat.com> <87ilqn4spx.fsf@oldenburg.str.redhat.com> <877d734qne.fsf@oldenburg.str.redhat.com> <87bkwfxkhg.fsf@oldenburg.str.redhat.com> <87levifvwm.fsf@oldenburg.str.redhat.com> <87h766ftx0.fsf@oldenburg.str.redhat.com> Date: Tue, 03 May 2022 18:57:11 +0200 In-Reply-To: (H. J. Lu's message of "Tue, 3 May 2022 09:46:55 -0700") Message-ID: <87czguftaw.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2022 16:57:25 -0000 * H. J. Lu: > On Tue, May 3, 2022 at 9:44 AM Florian Weimer wrote: >> >> * H. J. Lu: >> >> > On Tue, May 3, 2022 at 9:01 AM Florian Weimer wrote: >> >> >> >> * H. J. Lu: >> >> >> >> > The startup codes can't use cancellation before it is ready. Do we need to >> >> > check SHARED in this case? >> >> >> >> I think __libc_fatal shouldn't be a cancellation point. That's not >> >> really related to SHARED. >> > >> > Should we define _startup_fatal unconditionally and always define >> > I386_USE_SYSENTER as 0 for i386 so that _startup_fatal can be >> > used safely during startup? >> >> Hmm. Isn't that what my patch does? >> > > Your patch still checks BUILD_PIE_DEFAULT and SHARED. Ah, I see, thanks. You are right, the i386 version should define I386_USE_SYSENTER unconditionally. Will fix. Florian