public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
Cc: fweimer@redhat.com,  Carlos O'Donell <carlos@redhat.com>
Subject: Re: [PATCH 1/2] localedef: Update LC_MONETARY handling (Bug 28845)
Date: Thu, 17 Feb 2022 15:51:38 +0100	[thread overview]
Message-ID: <87czjlr1fp.fsf@igel.home> (raw)
In-Reply-To: <20220205025700.3728228-2-carlos@redhat.com> (Carlos O'Donell via Libc-alpha's message of "Fri, 4 Feb 2022 21:56:59 -0500")

On Feb 04 2022, Carlos O'Donell via Libc-alpha wrote:

> ISO C17, POSIX Issue 7, and ISO 30112 all allow the char*
> types to be empty strings i.e. "", integer or char values to
> be -1 or CHAR_MAX respectively, with the exception of
> decimal_point which must be non-empty in ISO C.
>
> We include a broad comment talking about harmonizing ISO C,
> POSIX, ISO 30112, and the default C/POSIX locale for glibc.
>
> We reorder all setting based on locale/categories.def order.
>
> We soften all missing definitions from errors to warnings when
> defaults exist.
>
> Given that ISO C, POSIX and ISO 30112 allow the empty string
> we change LC_MONETARY handling of mon_decimal_point to allow
> the empty string.  If mon_decimal_point is not defined at all
> then we pick the existing legacy glibc default value of
> <U002E> i.e. ".".
>
> We also set the default for mon_thousands_sep_wc at the
> same time as mon_thousands_sep, but this is not a change in
> behaviour, it is always either a matching value or L'\0',
> but if in the future we change the default to a non-empty
> string we would need to update both at the same time.
>
> Tested on x86_64 and i686 without regressions.
> Tested with install-locale-archive target.
> Tested with install-locale-files target.

Ok.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

  parent reply	other threads:[~2022-02-17 14:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-05  2:56 [PATCH 0/2] Improve LC_MONETARY handling Carlos O'Donell
2022-02-05  2:56 ` [PATCH 1/2] localedef: Update LC_MONETARY handling (Bug 28845) Carlos O'Donell
2022-02-08  3:46   ` DJ Delorie
2022-02-17 14:51   ` Andreas Schwab [this message]
2022-02-05  2:57 ` [PATCH 2/2] localedata: Do not generate output if warnings were present Carlos O'Donell
2022-02-08  3:51   ` DJ Delorie
2022-02-17 14:52   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czjlr1fp.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=carlos@redhat.com \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).