From: Florian Weimer <fweimer@redhat.com>
To: Tom Coldrick via Libc-alpha <libc-alpha@sourceware.org>
Cc: Tom Coldrick <thomas.coldrick@codethink.co.uk>
Subject: Re: Inconsistent libm-err ULP Table Generation for RISC-V
Date: Fri, 11 Feb 2022 17:16:27 +0100 [thread overview]
Message-ID: <87czjttm3o.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220211150034.okg7edbpmo6yqkgz@menegroth> (Tom Coldrick via Libc-alpha's message of "Fri, 11 Feb 2022 15:00:34 +0000")
* Tom Coldrick via Libc-alpha:
> While performing some reproducibility testing of glibc builds, we noticed that
> the ULP values for RISC-V in the libm section of libc.info-8 can change between
> builds. The root cause of this is that both
> sysdeps/riscv/rv32/rvd/libm-test-ulps-name and
> sysdeps/riscv/rv64/rvd/libm-test-ulps-name contain "RISC-V", which means they
> collide in the generation of the table.
>
> The net result is that the values in the ULP value table could be either the
> 32-bit variant or the 64-bit variant, with no indication as to which is used.
> The determining factor of which is used is an unsorted call to Python's
> os.walk(), which gives results in an order dependent upon the filesystem
> implementation on which it was called (that is, whatever order readdir() gives.)
> This can cause reproducibility issues, as well as meaning that the values in the
> manual are unclear on which variant they are for.
>
> I noticed that MIPS has 32- and 64-bit variants in separate columns, should this
> be done for RISC-V too?
I guess you could also have a shared sysdeps/riscv/libm-test-ulps-name
file. Is it valuable to track accuracy separately for different RISC-V
variants?
Thanks,
Florian
next prev parent reply other threads:[~2022-02-11 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 15:00 Tom Coldrick
2022-02-11 16:16 ` Florian Weimer [this message]
2022-02-11 17:39 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czjttm3o.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=thomas.coldrick@codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).