From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id D578F3858D3C for ; Mon, 27 Sep 2021 14:48:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D578F3858D3C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-109-bJXLcqUOPUaNti1BV_ogXw-1; Mon, 27 Sep 2021 10:48:16 -0400 X-MC-Unique: bJXLcqUOPUaNti1BV_ogXw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 504E8100C669; Mon, 27 Sep 2021 14:48:15 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.176]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5531D5F706; Mon, 27 Sep 2021 14:48:14 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: "H.J. Lu via Libc-alpha" Subject: Re: [PATCH] Disable symbol hack in libc_nonshared.a References: <20210924164131.2326532-1-hjl.tools@gmail.com> <87mtnygn7h.fsf@oldenburg.str.redhat.com> Date: Mon, 27 Sep 2021 16:48:11 +0200 In-Reply-To: (H. J. Lu's message of "Mon, 27 Sep 2021 07:44:18 -0700") Message-ID: <87czougjmc.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Sep 2021 14:48:20 -0000 * H. J. Lu: > On Mon, Sep 27, 2021 at 6:30 AM Florian Weimer wrote= : >> >> * H. J. Lu via Libc-alpha: >> >> > Don't reference __GI_memmove, __GI_memset, __GI_memcpy, __divdi3_inter= nal, >> > __udivdi3_internal and __moddi3_internal in libc_nonshared.a. >> >> Patch looks correct me. Commit subject should say =E2=80=9Clib*_nonshar= ed.a=E2=80=9D >> (it's not restricted to libc, despite the macro name). > > The symbol hack only applies to libc: > I am checking in my patch ASIS. Yes, you are right. Thanks. Florian