public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: posix/tst-spawn5 failes under make -j
Date: Fri, 09 Jul 2021 11:45:51 +0200	[thread overview]
Message-ID: <87czrrizw0.fsf@oldenburg.str.redhat.com> (raw)

This patch adds some additional diagonstics:

diff --git a/posix/tst-spawn5.c b/posix/tst-spawn5.c
index 277b848794..5ba7c7fadb 100644
--- a/posix/tst-spawn5.c
+++ b/posix/tst-spawn5.c
@@ -116,7 +116,11 @@ handle_restart (int argc, char *argv[])
 	  fds[i].found = found = true;
 
       if (!found)
-        FAIL_EXIT1 ("unexpected open file descriptor: %ld", fd);
+	{
+	  char *path = xasprintf ("/proc/self/fd/%s", e->d_name);
+	  char *resolved = xreadlink (path);
+	  FAIL_EXIT1 ("unexpected open file descriptor %ld: %s", fd, resolved);
+	}
     }
   closedir (dirp);
 
It's the pipe from the make job server:

error: tst-spawn5.c:122: unexpected open file descriptor 3: pipe:[9958839]

I think the test needs to be changed so that lowfd is passed across the
restart, and checking only considers descriptors >= lowfd.

Comments?

Thanks,
Florian


             reply	other threads:[~2021-07-09  9:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09  9:45 Florian Weimer [this message]
2021-07-09 13:10 ` Adhemerval Zanella
2021-07-09 13:41   ` Florian Weimer
2021-07-09 14:17     ` Adhemerval Zanella
2021-07-09 18:40       ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czrrizw0.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).