From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by sourceware.org (Postfix) with ESMTP id 29A5E385AC2B
 for <libc-alpha@sourceware.org>; Fri, 25 Jun 2021 09:05:07 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 29A5E385AC2B
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-125-JMDj-gwbNPKRTvqr4ZcgPw-1; Fri, 25 Jun 2021 05:05:05 -0400
X-MC-Unique: JMDj-gwbNPKRTvqr4ZcgPw-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
 [10.5.11.22])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 38B311005E53;
 Fri, 25 Jun 2021 09:05:04 +0000 (UTC)
Received: from oldenburg.str.redhat.com (ovpn-112-228.ams2.redhat.com
 [10.36.112.228])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D5811000358;
 Fri, 25 Jun 2021 09:05:03 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: libc-alpha@sourceware.org,  schwab@linux-m68k.org
Subject: Re: [PATCH v2] iconvconfig: Fix multiple issues
References: <20210625090128.316837-1-siddhesh@sourceware.org>
Date: Fri, 25 Jun 2021 11:05:01 +0200
In-Reply-To: <20210625090128.316837-1-siddhesh@sourceware.org> (Siddhesh
 Poyarekar's message of "Fri, 25 Jun 2021 14:31:28 +0530")
Message-ID: <87czsagvr6.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=unavailable autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Jun 2021 09:05:08 -0000

* Siddhesh Poyarekar:

> @@ -519,11 +520,12 @@ module_compare (const void *p1, const void *p2)
>  /* Create new module record.  */
>  static void
>  new_module (const char *fromname, size_t fromlen, const char *toname,
> -	    size_t tolen, const char *directory,
> +	    size_t tolen, const char *dir_in,
>  	    const char *filename, size_t filelen, int cost, size_t need_ext)
>  {
>    struct module *new_module;
> -  size_t dirlen = strlen (directory) + 1;
> +  size_t dirlen = strlen (dir_in) + 1;
> +  const char *directory = xstrdup (dir_in);

Sorry, why is this copy needed?

Thanks,
Florian