From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 806BA3896C26 for ; Wed, 19 May 2021 12:36:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 806BA3896C26 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-147-MTl3q8yuM4y0Z8VoK1QVxA-1; Wed, 19 May 2021 08:36:02 -0400 X-MC-Unique: MTl3q8yuM4y0Z8VoK1QVxA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A115C107ACC7; Wed, 19 May 2021 12:36:01 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-137.ams2.redhat.com [10.36.112.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C77185D9CC; Wed, 19 May 2021 12:36:00 +0000 (UTC) From: Florian Weimer To: Szabolcs Nagy Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 00/10] nptl: Complete libpthread removal References: <20210519115738.GS9028@arm.com> Date: Wed, 19 May 2021 14:35:58 +0200 In-Reply-To: <20210519115738.GS9028@arm.com> (Szabolcs Nagy's message of "Wed, 19 May 2021 12:57:39 +0100") Message-ID: <87cztm295d.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2021 12:36:10 -0000 * Szabolcs Nagy: > The 05/18/2021 16:24, Florian Weimer via Libc-alpha wrote: >> This series finally removes libpthread for Linux/NPTL. > > sorry i don't know when this started but in libc.a > now i see > > cnd_wait.o: > 0000000000000000 T __cnd_wait > 0000000000000000 W cnd_wait > U __pthread_cond_wait > > and __pthread_cond_wait is not defined anywhere. > (only a 3 _ prefix version) > > (in cnd_wait.os i see > U __GI___pthread_cond_wait > which is a hidden symbol in libc.so now) > > so now static linking code with cnd_wait fails. Ugh, I thought the linknamespace tests would cover that. This is a generic issue related to how libc_hidden_ver is defined: It does not create an alias as one might expect for the static libc, but actually expands to nothing. I hacked around this with an explicit strong_alias in some places, but it looks like I missed a few cases. Should we try to change the definition of libc_hidden_ver, or add more strong_alias directives? Thanks, Florian