From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 8C9663857C66 for ; Fri, 7 May 2021 09:23:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8C9663857C66 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-95-gc79FCYqMe2q0avDsmfVLA-1; Fri, 07 May 2021 05:23:53 -0400 X-MC-Unique: gc79FCYqMe2q0avDsmfVLA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 66E271923779; Fri, 7 May 2021 09:23:52 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-137.ams2.redhat.com [10.36.112.137]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0864110016FD; Fri, 7 May 2021 09:23:50 +0000 (UTC) From: Florian Weimer To: Andreas Schwab Cc: Martin Sebor via Libc-alpha , Martin Sebor , Joseph Myers Subject: Re: [PATCH] more out of bounds checking improvements References: <176ba75f-4299-073f-8319-66dbf9fe3f42@gmail.com> <87k0ot9trs.fsf@oldenburg.str.redhat.com> <87v98d6ldm.fsf@oldenburg.str.redhat.com> <2a7e377d-60c8-313b-9422-6cd0b4f5224c@gmail.com> <87h7je99xi.fsf@igel.home> Date: Fri, 07 May 2021 11:24:10 +0200 In-Reply-To: <87h7je99xi.fsf@igel.home> (Andreas Schwab's message of "Fri, 07 May 2021 11:20:57 +0200") Message-ID: <87czu2ew1x.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 09:23:59 -0000 * Andreas Schwab: > makedb.c: In function 'write_output': > makedb.c:797:7: error: 'writev' specified size 4294967295 exceeds maximum object size 2147483647 [-Werror=stringop-overflow=] > 797 | if (writev (fd, iov, iov_nelts) != keydataoffset) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from ../include/sys/uio.h:2, > from makedb.c:39: > ../misc/sys/uio.h:52:16: note: in a call to function 'writev' declared with attribute 'read_only (2, 3)' > 52 | extern ssize_t writev (int __fd, const struct iovec *__iovec, int __count) > | ^~~~~~ > cc1: all warnings being treated as errors > make[2]: *** [../o-iterator.mk:9: /home/abuild/rpmbuild/BUILD/glibc-2.33.9000.515.g3bf0b4f2cd/cc-base/nss/makedb.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/glibc-2.33.9000.515.g3bf0b4f2cd/nss' > make[1]: *** [Makefile:479: nss/others] Error 2 > make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/glibc-2.33.9000.515.g3bf0b4f2cd' > make: *** [Makefile:9: all] Error 2 Are you building with -DNDEBUG? Yes, the assert approach will not work in that case. Thanks, Florian