From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21]) by sourceware.org (Postfix) with ESMTPS id 27561385800A for ; Thu, 25 Mar 2021 13:36:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 27561385800A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=deneb.enyo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de Received: from [172.17.203.2] (port=38601 helo=deneb.enyo.de) by albireo.enyo.de ([172.17.140.2]) with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1lPQA5-0000vH-4Y; Thu, 25 Mar 2021 13:36:33 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.92) (envelope-from ) id 1lPQA5-0002B2-0u; Thu, 25 Mar 2021 14:36:33 +0100 From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH v2 02/14] nptl: Remove send from libpthread References: <20210319202914.2475530-1-adhemerval.zanella@linaro.org> <20210319202914.2475530-3-adhemerval.zanella@linaro.org> Date: Thu, 25 Mar 2021 14:36:33 +0100 In-Reply-To: <20210319202914.2475530-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 19 Mar 2021 17:29:02 -0300") Message-ID: <87czvnnyn2.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Mar 2021 13:36:37 -0000 * Adhemerval Zanella via Libc-alpha: > The libc version is identical and built with same flags. Both aarch64 > and nios2 also requires to export __send and tt was done previously with > the HAVE_INTERNAL_SEND_SYMBOL (which forced the symbol creation). > > All __send callers are internal to libc and the original issue that > required the symbol export was due a missing libc_hidden_def. So > a compat symbol is added for __send and the libc_hidden_def is > defined regardless. What's the intended compat symbol status of __send with this patch? Presently, it's a compat symbol on aarch64 and nios2 only, I think. This is sufficient to avoid the additional of the __send@@GLIBC_2.34 symbol there. The other architectures already have a public __send symbol, so the issue does not apply to them. I think this split approach is okay for now, and as far as I can tell, this patch achieves it, so I think it should go in.