From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 04E913857C5F for ; Wed, 24 Mar 2021 14:38:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 04E913857C5F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-EL-kaj7yN9WPUXm2p2HeFQ-1; Wed, 24 Mar 2021 10:38:05 -0400 X-MC-Unique: EL-kaj7yN9WPUXm2p2HeFQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC87010922C0; Wed, 24 Mar 2021 14:38:04 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-80.ams2.redhat.com [10.36.112.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD0621054FD6; Wed, 24 Mar 2021 14:38:03 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 25/37] nptl: Move pthread_getspecific, __pthread_getspecific into libc References: <731956b0cd5783de2b09d1754bee65456791e4ea.1615914632.git.fweimer@redhat.com> <6418c3a1-3ead-8a0d-8312-2bc16b399d98@linaro.org> Date: Wed, 24 Mar 2021 15:38:23 +0100 In-Reply-To: <6418c3a1-3ead-8a0d-8312-2bc16b399d98@linaro.org> (Adhemerval Zanella's message of "Wed, 24 Mar 2021 11:12:18 -0300") Message-ID: <87czvowra8.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 14:38:09 -0000 * Adhemerval Zanella: >> diff --git a/nptl/Versions b/nptl/Versions >> index d44958f5b6..218d6bbbf8 100644 >> --- a/nptl/Versions >> +++ b/nptl/Versions >> @@ -1,5 +1,6 @@ >> libc { >> GLIBC_2.0 { >> + __pthread_getspecific; >> __pthread_key_create; >> __pthread_once; >> _pthread_cleanup_pop; >> @@ -29,6 +30,7 @@ libc { >> pthread_equal; >> pthread_exit; >> pthread_getschedparam; >> + pthread_getspecific; >> pthread_key_create; >> pthread_mutex_destroy; >> pthread_mutex_init; >> @@ -88,8 +90,10 @@ libc { >> } >> GLIBC_2.34 { >> __pthread_cleanup_routine; >> + __pthread_getspecific; > > Why do we need a __pthread_getspecific for 2.34? I can turn __pthread_getspecific into a compat symbol once tss_get has been moved into libc. Then we do not need __pthread_getspecific@@GLIBC_2.34 anymore. As discussed before, I do not want to introduce __pthread_getspecific@@GLIBC_PRIVATE because relinking applications which previously used the public __pthread_getspecific symbol will suddenly switch to the internal GLIBC_PRIVATE symbol, which would be a regression. (__pthread_getspecific is not used by libstdc++.) Thanks, Florian