From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) by sourceware.org (Postfix) with ESMTPS id 4D3963857C5F for ; Fri, 19 Mar 2021 10:07:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4D3963857C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=whitebox@nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4F201z2fNyz1rwbW; Fri, 19 Mar 2021 11:07:35 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4F201z1KB0z1sP6j; Fri, 19 Mar 2021 11:07:35 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id XJajdV2W5vSs; Fri, 19 Mar 2021 11:07:34 +0100 (CET) X-Auth-Info: 1j+XhDHjs9rg183iPX884ZI/qLPBhjOheQFRIJAPpC6lFYQj8yJqSAtbjPCRXFso Received: from igel.home (ppp-46-244-191-242.dynamic.mnet-online.de [46.244.191.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 19 Mar 2021 11:07:33 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 42FB02C31AD; Fri, 19 Mar 2021 11:07:33 +0100 (CET) From: Andreas Schwab To: YunQiang Su Cc: libc-alpha@sourceware.org, syq@debian.org, jiaxun.yang@flygoat.com, aurelien@aurel32.net, macro@orcam.me.uk Subject: Re: [PATCH v2 2/2] MIPS: N64, make xstat as wrapper of generic fstatat References: <20210319011837.3883510-1-yunqiang.su@cipunited.com> <20210319011837.3883510-2-yunqiang.su@cipunited.com> X-Yow: If this is the DATING GAME I want to know your FAVORITE PLANET! Do I get th' MICROWAVE MOPED? Date: Fri, 19 Mar 2021 11:07:33 +0100 In-Reply-To: <20210319011837.3883510-2-yunqiang.su@cipunited.com> (YunQiang Su's message of "Fri, 19 Mar 2021 01:18:37 +0000") Message-ID: <87czvv78yi.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2021 10:07:39 -0000 On Mär 19 2021, YunQiang Su wrote: > diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n64/fxstat.c b/sysdeps/unix/sysv/linux/mips/mips64/n64/fxstat.c > new file mode 100644 > index 0000000000..037b2bb080 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/mips/mips64/n64/fxstat.c > @@ -0,0 +1,27 @@ > +/* fxstat using old-style Unix stat system call. > + Copyright (C) 1991-2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#include > + > +/* Get information about the file NAME in BUF. */ > +int > +__fxstat (int vers, int fd, struct stat *buf) > +{ > + return __fxstatat(vers, fd, "", buf, AT_EMPTY_PATH); That needs to reject fd < 0. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."